Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing system diagram styling #587

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Fixing system diagram styling #587

merged 2 commits into from
Oct 19, 2023

Conversation

therealryan
Copy link
Collaborator

@therealryan therealryan commented Oct 19, 2023

Mermaid behaviour seems to have changed such that marker IDs have the document ID prefixed on them. This broke the sneaky diagram restyling added in #456 - we were lacking the arrows on the lines.

@therealryan therealryan changed the title mermaid behaviour appears to have changed Fixing system diagram styling Oct 19, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@therealryan therealryan merged commit 2e4aeb3 into main Oct 19, 2023
10 checks passed
@therealryan therealryan deleted the system_diagram_styling branch October 19, 2023 10:53
@therealryan therealryan added bug Something isn't working javascript Pull requests that update Javascript code labels Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant