Diff demo: lowercase only #567
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -40,7 +40,7 @@ public Map<String, Integer> histogram( String text, String characters ) { | |||
|
|
|||
| private static Map<String, Integer> histogram( String text, Predicate<Character> test ) { | |||
| Map<String, Integer> m = new TreeMap<>(); | |||
| Optional.ofNullable( text ) | |||
| Optional.ofNullable( text.toLowerCase() ) | |||
There was a problem hiding this comment.
This application change satisfies the new requirement
| @@ -28,7 +28,7 @@ public Map<String, Integer> histogram( String text ) { | |||
| @Override | |||
| public Map<String, Integer> histogram( String text, String characters ) { | |||
| LOG.info( "Counting [{}] characters in '{}'", characters, text ); | |||
| Optional<Set<Character>> queried = Optional.ofNullable( characters ) | |||
| Optional<Set<Character>> queried = Optional.ofNullable( characters.toLowerCase() ) | |||
There was a problem hiding this comment.
No sense trying to count upper-case characters any more.
Canny reviewers (and mutation testing) will spot that this change is not exercised by our testing - we don't have any flows where the set of characters to count includes upper-case values.
| List<Object> counts = Arrays.asList( " ", 2, "!", 1, "'", 1, "a", 1, "b", 2, "c", 1, "e", 1, | ||
| "i", 1, "k", 1, "l", 2 ); | ||
| String countText = "{\" \":2,\"!\":1,\"'\":1,\"a\":1," | ||
| + "\"b\":2,\"c\":1,\"e\":1,\"i\":1,\"k\":1,\"l\":2}"; |
There was a problem hiding this comment.
This is the impact of the change on what gets stored to the DB
|
|
||
| List<Object> deletes = valueFill( DELETE, | ||
| " ", "!", "H", "d", "l", "r", "w" ); | ||
| " ", "!", "h", "d", "l", "r", "w" ); |
There was a problem hiding this comment.
More test-data changes to make our existing test reflect the new behaviour of the system.
| .update( HISTOGRAM, | ||
| rq( ".+", "HELLO WORLD!" ) ) ); | ||
|
|
||
| members( flatten( empty, hello, yodel, vowels, shouty ) ); |
There was a problem hiding this comment.
We're also adding a new flow to make it really obvious that upper-case characters are counted as lower-case.
| "RESPONSES <-- HISTOGRAM", | ||
| "1744EA709AEE2A8718AE343B15C399BC 0009 1.6 KiB" ); | ||
| "BAEF88E9F3765D7D563B1563C34255C6 0010 1.8 KiB" ); | ||
| } |
There was a problem hiding this comment.
We've changed a bunch of message content - this diff highlights exactly which services are affected.
| "| 0 0.00%│ 0 0.00%|", | ||
| "| 0 0.00%│ 1 7.14%|", | ||
| "| 0 0.00%│ 1 6.67%|", | ||
| "| 0 0.00%│ 0 0.00%|", | ||
| "| 0 0.00%│ 0 0.00%|", | ||
| "| 0 0.00%│ 0 0.00%|", |
There was a problem hiding this comment.
The addition of the new flow has shifted the debt histogram about a bit, but note that the "Total Debt" figure has not increased. This indicates that we chose the best possible derivation basis for our new flow.
|
Extremely important business requirement update for the example app! We should be ignoring character case: return a count of characters after converting all input to lowercase.
We're not going to merge this, it's just to provide a demo of the model-diff function of the execution report.