[CodeArena] - [L-01/N-18/L-20] : Remove 1:1 linkage between factory & reserve #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrien-supizet
approved these changes
Dec 13, 2021
test/unit/NestedAsset.unit.ts
Outdated
| @@ -129,7 +127,7 @@ describe("NestedAsset", () => { | |||
|
|
|||
| it("should revert if the caller is not the factory", async () => { | |||
| await expect(asset.connect(bob).backfillTokenURI(1, bob.address, "ipfs://newTokenURI")).to.be.revertedWith( | |||
| "NA: FORBIDDEN_NOT_FACTORY", | |||
| "FH: FORBIDDEN", | |||
There was a problem hiding this comment.
💅 Typo here in contract name
adrien-supizet
added
Fix and merge
maximebrugel
force-pushed
the
codearena-32
branch
from
7ec0d49 to
74bf1f6
Compare
maximebrugel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues =>
The idea here is to introduce an abstract contract
OwnableFactoryHandlerto remove duplicated code towardssupportedFactories(and associated functions/modifier). AndNestedReserveis now anOwnableFactoryHandler.