Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing migration methods from Laravel #748

Open
6 of 35 tasks
maicol07 opened this issue Jul 5, 2022 · 6 comments
Open
6 of 35 tasks

Add missing migration methods from Laravel #748

maicol07 opened this issue Jul 5, 2022 · 6 comments
Labels
enhancement A feature that exists, works as intended but needs to be improved feature request A feature that does not yet exist but will be a good addition to the library

Comments

@maicol07 maicol07 added enhancement A feature that exists, works as intended but needs to be improved feature request A feature that does not yet exist but will be a good addition to the library labels Jul 5, 2022
@josephmancuso
Copy link
Member

Are you able to open a PR and add these?

@josephmancuso
Copy link
Member

josephmancuso commented Jul 5, 2022

It would actually be pretty straight forward:

  1. add the method to the blueprint class
  2. add the column map to each Platform class (sqlite, mysql, Postgres and mssql)
  3. Write tests in each other test_{database}_schema_builder.py files

@maicol07
Copy link
Contributor Author

maicol07 commented Jul 5, 2022

Yes, I can look at them

@josephmancuso
Copy link
Member

Thanks

@yubarajshrestha
Copy link
Contributor

@maicol07 macAddress already exists here's the code in orm

def macaddr(self, column, length=255, nullable=False):
        """Sets a column to be the macaddr representation for the table.

        Arguments:
            column {string} -- The column name.

        Keyword Arguments:
            nullable {bool} -- Whether the column is nullable. (default: {False})

        Returns:
            self
        """
        self._last_column = self.table.add_column(
            column, "macaddr", length=255, nullable=nullable
        )
        return self

@maicol07
Copy link
Contributor Author

@maicol07 macAddress already exists here's the code in orm

def macaddr(self, column, length=255, nullable=False):
        """Sets a column to be the macaddr representation for the table.

        Arguments:
            column {string} -- The column name.

        Keyword Arguments:
            nullable {bool} -- Whether the column is nullable. (default: {False})

        Returns:
            self
        """
        self._last_column = self.table.add_column(
            column, "macaddr", length=255, nullable=nullable
        )
        return self

Thanks! Checked the item in the list!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature that exists, works as intended but needs to be improved feature request A feature that does not yet exist but will be a good addition to the library
Projects
None yet
Development

No branches or pull requests

3 participants