Plotting - major steps towards final product #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Streamlined certain aspects of plotting and removed ability to modify x-tick location. More importantly, discovered ax.inset_axes([x_loc, y_loc, x_width, y_height], transform=ax.transData) that will allow floating y-axis for difference. At present, ready to implement floating axis.
bbelderbos
reviewed
Aug 31, 2020
|
|
||
|
|
||
| class Figure: | ||
| def __init__(self, pliffy_data, plot_info, estimates, ax_ab): |
There was a problem hiding this comment.
should it be ax_ab=None?
|
|
||
| def _plot_raw_data(self): | ||
| if ( | ||
| self.pliffy_data.design == "paired" |
There was a problem hiding this comment.
constant, also would expect and to be part of the () formatting?
| def _create_diff_axis(self): | ||
| pass | ||
|
|
||
| def _plot_ab(self): |
There was a problem hiding this comment.
I like you signaled what is "internal"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented the basic plotting for the two groups (mean, confidence intervals, raw data). I started a somewhat hacky version of the difference axis (right y-axis), but I was not happy with it. I did some googling and found this new functionality in Matplotlib which will allow me to create my floating y-axis rather simply. I am super stocked about this! It will require a bit of figuring out to get it lined up, but it will be worth it.
I am tacking the inset axis next, and hopefully once I have done that I will only have a few more tweaks to add.