Flip order of retrieval for doc pages

* In case someone requests a page that doesn't exist don't bother reading the file list Post fix for OpenUserJS#202
Martii · Nov 5, 2015 · 7f9011d · 7f9011d
1 parent b2d515e
commit 7f9011d
Showing 1 changed file with 27 additions and 27 deletions.
diff --git a/controllers/document.js b/controllers/document.js
@@ -70,33 +70,6 @@ exports.view = function (aReq, aRes, aNext) {
 
     //--- Tasks
 
-    // Read file listing
-    tasks.push(
-      function (aCallback) {
-        fs.readdir(documentPath, function (aErr, aFileList) {
-          var file = null;
-
-          if (aErr || !aFileList) {
-            aCallback({ statusCode: 500, statusMessage : 'Error retrieving page list' });
-            return;
-          }
-
-          // Dynamically create a file listing of the pages
-          options.fileList = [];
-          for (file in aFileList) {
-            if (/\.md$/.test(aFileList[file])) {
-              options.fileList.push({
-                href: aFileList[file].replace(/\.md$/, ''),
-                textContent: aFileList[file].replace(/\.md$/, '').replace(/-/g, ' ')
-              });
-            }
-          }
-
-          aCallback(null);
-        });
-      }
-    );
-
     // Read the requested md file contents
     tasks.push(
       function (aCallback) {
@@ -131,6 +104,33 @@ exports.view = function (aReq, aRes, aNext) {
         });
       }
     );
+
+    // Read file listing
+    tasks.push(
+      function (aCallback) {
+        fs.readdir(documentPath, function (aErr, aFileList) {
+          var file = null;
+
+          if (aErr || !aFileList) {
+            aCallback({ statusCode: 500, statusMessage : 'Error retrieving page list' });
+            return;
+          }
+
+          // Dynamically create a file listing of the pages
+          options.fileList = [];
+          for (file in aFileList) {
+            if (/\.md$/.test(aFileList[file])) {
+              options.fileList.push({
+                href: aFileList[file].replace(/\.md$/, ''),
+                textContent: aFileList[file].replace(/\.md$/, '').replace(/-/g, ' ')
+              });
+            }
+          }
+
+          aCallback(null);
+        });
+      }
+    );
   }
   else {
     // Page metadata