chore: externalize semver

Signed-off-by: Martichou <[email protected]>
Martichou · Aug 3, 2024 · 01fb516 · 01fb516
1 parent b9e1cfb
commit 01fb516
Show file tree

Hide file tree

Showing 7 changed files with 25 additions and 13 deletions.
diff --git a/app/common/vue_lib/package.json b/app/common/vue_lib/package.json
@@ -11,12 +11,14 @@
     "@tauri-apps/api": "^1.5.6",
     "@tauri-apps/plugin-store": "2.0.0-beta.5",
     "pinia": "^2.2.0",
+    "semver": "^7.6.3",
     "vue": "^3.4.35"
   },
   "devDependencies": {
     "@stylistic/eslint-plugin": "^2.1.0",
     "@vue/eslint-config-typescript": "13.0.0",
     "eslint": "8.57.0",
+    "@types/semver": "^7.5.8",
     "eslint-config-prettier": "9.1.0",
     "eslint-plugin-node": "11.1.0",
     "eslint-plugin-security": "3.0.0",

diff --git a/app/common/vue_lib/pnpm-lock.yaml b/app/common/vue_lib/pnpm-lock.yaml
diff --git a/app/common/vue_lib/src/index.ts b/app/common/vue_lib/src/index.ts
@@ -4,6 +4,7 @@ import { autostartKey, DisplayedItem, downloadPathKey, numberToVisibility, realc
 import { SendInfo } from '@martichou/core_lib/bindings/SendInfo';
 import { ChannelMessage } from '@martichou/core_lib/bindings/ChannelMessage';
 import { ChannelAction } from '@martichou/core_lib';
+import { gt } from 'semver';
 
 export * from './types';
 export * from './stores/useToastStore';
@@ -174,7 +175,7 @@ export async function getDownloadPath(vm: TauriVM) {
 	vm.downloadPath = await vm.store.get(downloadPathKey) ?? undefined;
 }
 
-export async function getLatestVersion(vm: TauriVM, gt: (a: string, b: string) => boolean) {
+export async function getLatestVersion(vm: TauriVM) {
 	try {
 		const response = await fetch('https://api.github.com/repos/martichou/rquickshare/releases/latest');
 		if (!response.ok) {

diff --git a/app/legacy/src/components/HomePage.vue b/app/legacy/src/components/HomePage.vue
@@ -343,7 +343,6 @@
 </template>
 
 <script lang="ts">
-import { gt } from 'semver'
 import { ref, nextTick } from 'vue'
 import { UnlistenFn, listen } from '@tauri-apps/api/event'
 import { Store } from 'tauri-plugin-store-api';
@@ -532,7 +531,7 @@ export default {
 				})
 			);
 
-			await this.getLatestVersion(this, gt);
+			await this.getLatestVersion(this);
 		});
 	},
 

diff --git a/app/legacy/vite.config.ts b/app/legacy/vite.config.ts
@@ -40,7 +40,7 @@ export default defineConfig({
 		sourcemap: !!process.env.TAURI_DEBUG,
 		emptyOutDir: true,
 		rollupOptions: {
-			external: ['pinia']
+			external: ['pinia', 'semver']
 		}
 	},
 	// See https://vitest.dev/config/

diff --git a/app/main/src/components/HomePage.vue b/app/main/src/components/HomePage.vue
@@ -345,7 +345,6 @@
 </template>
 
 <script lang="ts">
-import { gt } from 'semver'
 import { ref, nextTick } from 'vue'
 import { UnlistenFn, listen } from '@tauri-apps/api/event'
 import { invoke } from '@tauri-apps/api/core'
@@ -534,7 +533,7 @@ export default {
 				})
 			);
 
-			await this.getLatestVersion(this, gt);
+			await this.getLatestVersion(this);
 		});
 	},
 

diff --git a/app/main/vite.config.ts b/app/main/vite.config.ts
@@ -40,7 +40,7 @@ export default defineConfig({
 		sourcemap: !!process.env.TAURI_DEBUG,
 		emptyOutDir: true,
 		rollupOptions: {
-			external: ['pinia']
+			external: ['pinia', 'semver']
 		}
 	},
 	// See https://vitest.dev/config/