Better syntax for optional / required dependencies #4

MarshallOfSound · 2018-04-07T16:40:37Z

Basically modules now have a relationship property which is an instance of the DepRelationship class which has the documented API.

getType(): DepType // The old depType value without OPTIONAL and DEV_OPTIONAL
getRequired(): DepRequireState // Optional vs Required

Tests have been updated accordingly

malept

Seems reasonable, modulo some docs fixes.

Remember to remove DEV_OPTIONAL from README.md.

malept · 2018-04-07T22:40:32Z

test/depTypes_spec.ts

+    /**
+     * These tests ensure that the method will not modify things that are identical
+     */
+    it('should report OPTIONAL < OPTIONAL', () => {


That description is not true...

MarshallOfSound force-pushed the better-opt branch 2 times, most recently from afa7a29 to 3800990 Compare April 7, 2018 16:44

Update logic to allow for opt/req and prod/dev/root

3800990

malept suggested changes Apr 7, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Better syntax for optional / required dependencies #4

Better syntax for optional / required dependencies #4

MarshallOfSound commented Apr 7, 2018 •

edited

Loading

malept left a comment

malept Apr 7, 2018

Better syntax for optional / required dependencies #4

Are you sure you want to change the base?

Better syntax for optional / required dependencies #4

Conversation

MarshallOfSound commented Apr 7, 2018 • edited Loading

malept left a comment

Choose a reason for hiding this comment

malept Apr 7, 2018

Choose a reason for hiding this comment

MarshallOfSound commented Apr 7, 2018 •

edited

Loading