Add support for beta electron versions

MarshallOfSound · Dec 17, 2017 · 1c425dc · 1c425dc
1 parent 051a62d
commit 1c425dc
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/index.js b/src/index.js
@@ -21,9 +21,10 @@ const install = (extensionReference, forceDownload = false) => {
   let chromeStoreID;
   if (typeof extensionReference === 'object' && extensionReference.id) {
     chromeStoreID = extensionReference.id;
-    if (!semver.satisfies(process.versions.electron, extensionReference.electron)) {
+    const electronVersion = process.versions.electron.split('-')[0];
+    if (!semver.satisfies(electronVersion, extensionReference.electron)) {
       return Promise.reject(
-        new Error(`Version of Electron: ${process.versions.electron} does not match required range ${extensionReference.electron} for extension ${chromeStoreID}`), // eslint-disable-line
+        new Error(`Version of Electron: ${electronVersion} does not match required range ${extensionReference.electron} for extension ${chromeStoreID}`), // eslint-disable-line
       );
     }
   } else if (typeof extensionReference === 'string') {

diff --git a/test/compat_spec.js b/test/compat_spec.js
@@ -28,6 +28,13 @@ describe('Extension Compatability Checker', () => {
     });
   });
 
+  describe('when using a compatable beta version of electron', () => {
+    it('should resolve the promise', () => {
+      process.versions.electron = '1.8.2-beta.3';
+      return installExtension(REACT_DEVELOPER_TOOLS).should.be.fulfilled;
+    });
+  });
+
   afterEach(() => {
     process.versions.electron = currentVersion;
   });