New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make 'pause after song' work #3793

Closed

Bertaz wants to merge 0 commits into MarshallOfSound:master from Bertaz:master

Bertaz commented Feb 12, 2020 •

edited

Loading

fixes #3383
closes #3565

Originally by @Glench
There may be a further issue with change:track being fired twice that warrants looking into.

This change is

welcome bot commented Feb 12, 2020

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

Run npm run lint locally to catch formatting errors earlier.
Include tests when adding/changing behavior.
Include screenshots and animated GIFs whenever possible.
If you added new translation strings ensure that you have added empty strings for all languages
If you added new functionality or modified existing functionality please ensure it is tested

Bertaz requested a review from MarshallOfSound

February 13, 2020 02:38

jostrander approved these changes

View reviewed changes

Bertaz closed this

Bertaz force-pushed the master branch from 8f2854a to 8202683 Compare

August 12, 2020 16:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet