Make thumbs up/down options in the tray menu work as checkboxes #3321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| icon: remote.getGlobal('PlaybackAPI').data.song.albumArt, | ||
| }); | ||
| window.GPM.rating.setRating(5); | ||
| if (window.GPM.rating.getRating() !== '5') { |
There was a problem hiding this comment.
Not 100% sure how this change is relevent or what it does? Can you either clarify or remove ❓
There was a problem hiding this comment.
Before, the "you just liked..." toast got fired every time the menu option was clicked - which was fine because once a song was already liked clicking the button again didn't do anything.
The menu option is now a toggle, so depending on whether the song is currently liked or not the rating either needs to be reset ("un-liked", as distinct from disliked) or set to 5.
Only in the latter case should the toast be shown. I didn't add an "un-liking" toast because I wasn't sure if that was the correct term to use.
(same argument in reverse applies to the dislike option)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the thumbs up/down options in the system tray work like checkboxes rather than plain buttons.
So when a track is played, if it has already been rated the appropriate option in the tray will be shown checked. Changing the rating or setting one for the first time, either through the tray or through the main player window, updates the other properly (so you can unrate a track through the tray which wasn't possible before).