Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Sign In may break in June 2019 #3545

Closed
MarshallOfSound opened this issue Apr 19, 2019 · 127 comments · Fixed by #3608
Closed

Google Sign In may break in June 2019 #3545

MarshallOfSound opened this issue Apr 19, 2019 · 127 comments · Fixed by #3608

Comments

@MarshallOfSound
Copy link
Owner

Just raising this pre-emptively as a tracking issue for electron/electron#17887

Unclear if whatever measures Google implement will affect Electron or if we can work around them locally. If it's just UA sniffing we can defeat that easily, I guess we'll just have to wait and see what happens.

@apt-itude
Copy link

I'm not sure if this is still being tracked, but as of the last few days, I can no longer use the app. It gets stuck at "Loading Music Library" indefinitely. This issue jumped out at me given the timing.

@sulymkaa

This comment has been minimized.

@MarshallOfSound
Copy link
Owner Author

It gets stuck at "Loading Music Library" indefinitely.

This was actually caused by an unrelated GPM incident. I hit it yesterday on one of my machines, deleting your cache and relaunching will fix it.

@jfries289
Copy link
Contributor

@MarshallOfSound I'm experiencing the same issue (OSX). I deleted the cache located at ~/Library/Caches/google-play-music-desktop-player, but the issue persists. Is there something else I should remove?

@Darktex
Copy link

Darktex commented Jul 3, 2019

This started happening to me too! I also deleted my cache at ~/Library/Caches/google-play-music-desktop-player to no avail :(

@cscuderi

This comment has been minimized.

@cscuderi
Copy link

I deleted the cache folder at: /Users/carlinscuderi/Library/Application Support/Google Play Music Desktop Player/Cache, restarted the application, and it now works.

@Darktex
Copy link

Darktex commented Jul 25, 2019

I haven't literally done anything but it started working on its own lol

@ervinb
Copy link
Contributor

ervinb commented Aug 9, 2019

I'm having issues signing in on W10.

Capture

@noizyboy
Copy link

Same issue here as @ervinb.

signin

@MarshallOfSound
Copy link
Owner Author

I just took the risk and signed out and signed in again, worked fine for me (even switched networks in the middle).

I think y'all are getting hit with an unfortunate A/B test. My best suggestion is to try one of the builds from master and see if it helps

@clingsmash
Copy link

clingsmash commented Aug 19, 2019

I'm having the same issue. I have tried releases from the 4.7 minor all the way back through master 4.50. I have signed in previously using this account on an old computer, but have not been able to successfully get past the login on W10

image

@MarshallOfSound
Copy link
Owner Author

@clingsmash Where does that "Learn more" link take you?

@noizyboy
Copy link

The learn more link takes you here:
https://support.google.com/accounts/answer/7675428

@benpetermorris
Copy link

benpetermorris commented Aug 21, 2019

I am also experiencing the "Couldn't sign you in" issue on a new install on W10 -- exactly the same result as @noizyboy's screenshot above. I installed and signed in successfully on another device a month or two ago, and I've been using the software for about a year without any other problems. (Great app, by the way!)

@GHubNH
Copy link

GHubNH commented Aug 21, 2019

Same here in Win10. "Couldn't sign you in" in 4.7 minor, 4.6.1 and in 4.5.0.
4.7 has a dialogue as shown in clingsmash.
4.6.1 and 4.5.0 display the slightly different dialogue in the 2 screen grabs above that.

@jimmoua
Copy link

jimmoua commented Aug 21, 2019

Getting the exact same sign-in issue on GNU/Linux...

@paulgittings
Copy link

"Couldn't sign you in" on Windows 7, new install, haven't used before.

@clingsmash
Copy link

I have a w7 and w 10 device if you need any testing done.

@craigrouse
Copy link

Same issue for me.

@Deckee
Copy link

Deckee commented Aug 23, 2019

I have hit the same issue, the OS is Debian 5 stretch. just get the "couldn't sign in" page after trying to sign in. on a fresh install. gpmdp is v4.6.1

@genocidalrobot
Copy link

also getting the "Couldn't Sign In" page on 4.6.1 in W10

@DennisTerrell
Copy link

Also experiencing the "Couldn't sign you in" issue on v4.6.1.

@Mushy-Snugglebites-badonkadonk

Verified issue on macOS

You are trying to sign in from a browser or app that doesn't allow us to keep your account secure.
Try using a different browser.

@LordPantaloons
Copy link

Just got this problem too, changed my password and got booted after a bit like I expected. tried to log in with new password and get this screen, using most recent version, windows 10. Curiously it lets me sign in with a different account but not the one I normally use. Ive changed passwords before and not had this problem.
ss+(2019-08-26+at+03 53 30)

@MarshallOfSound
Copy link
Owner Author

I've tried a few accounts and haven't seen this yet, I think Google is A/B testing this stuff. Not sure what else I can do without a way to repro this on my machine and try find a way around it

@LordPantaloons
Copy link

have you tried changing the password while signed in, letting it boot you and trying to sign in with the new password?

@AhoyLemon
Copy link

For anyone still having this issue on Windows 10, this subversion is allowing me to login with the 2FA enabled. Give it a try if you haven't already. Download Here

This one just worked for me.

@byeuji
Copy link

byeuji commented Dec 20, 2019

For anyone still having this issue on Windows 10, this subversion is allowing me to login with the 2FA enabled. Give it a try if you haven't already. Download Here

Who maintains this "subversion"? Is it just a past version of this same product, or a forked project of some kind? I just don't want to install some random exe.

@iamzloff
Copy link

iamzloff commented Dec 20, 2019 via email

@MarshallOfSound
Copy link
Owner Author

Those builds come directly from our CI --> https://ci.appveyor.com/project/MarshallOfSound/google-play-music-desktop-player-unofficial/builds/29394771/artifacts

Still trying to find the golden user agent folks, it's working for like 95% of cases but you can still get stuck on a bad page.

@byeuji
Copy link

byeuji commented Dec 20, 2019

Dunno if it helps narrow down at all, but my account is a grandfathered apps account (from the old beta) with 2FA enabled.
Thanks for your hard work on this.

@austinjordan
Copy link

Just adding a comment that I had the login error 'browser or app may not be secure', but downloading the latest build: https://ci.appveyor.com/project/MarshallOfSound/google-play-music-desktop-player-unofficial/builds/29394771/artifacts

Fixed the issue for me. [First time user]

@Xernium
Copy link

Xernium commented Dec 22, 2019

Next thing: This login fix works- It breaks the youtube music integration though.

@Xernium
Copy link

Xernium commented Dec 22, 2019

Bildschirmfoto 2019-12-22 um 18 04 02

Translated: Youtube music is not optimised for your browser. Search for updates or download google chrome. With a google chrome download button

@trevorscottprice
Copy link

I may be weighing in here again with limited context, but what if Google suddenly changes something that breaks all the fragile trial-and-error user agent work?

Has Google published any sort of API or even guidelines for doing apps like this? It would really suck to go through all this work just to watch it fall apart.

@dzek69
Copy link

dzek69 commented Dec 22, 2019

The guideline is NOT TO make apps like this :) This is why this is so painful to work around.

Google Music doesn't have any API, it's just a webpage, so GPMDP tries to wrap it around and inject stuff into with something that resembles "custom browser".

@cakeycakes
Copy link

cakeycakes commented Dec 24, 2019

The above solution isn't working for me. I still get the browser isn't secure when I try to log in. I tried using app password through google as well and still get that error.

Edit: I just tried this one: https://ci.appveyor.com/project/MarshallOfSound/google-play-music-desktop-player-unofficial/builds/29394771/artifacts

and it worked for me

@agc93
Copy link

agc93 commented Dec 26, 2019

Just going to reiterate for anyone like @cakeycakes or @austinjordan struggling to find CI builds (especially if AppVeyor or CircleCI builds don't show artifacts for you) check with https://gpmdp.azurewebsites.net to find the latest successful CI build for your platform.

@bestit-el-bardan
Copy link

@Xernium I had the same issue changing the UserAgent to "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:71.0) Gecko/20100101 Firefox/71.0" (my Firefox UserAgent) in "~/Library/Application Support/Google Play Music Desktop Player/json_store" fixes the issue for me.
I can log-in & use Youtube Music again! :)

@MarshallOfSound
Copy link
Owner Author

MarshallOfSound commented Dec 28, 2019

Hey Folks, thanks to some sleuthing by @Max9403 we think we have a build that let's you sign in, use GPM and use YTM 🎉

The RC builds are linked over here --> #3761 (comment)

If the build worked for you please 👍 that RC build comment, if they didn't work, please comment on that issue explaining in detail what didn't work. Please ensure that you don't comment the same thing as someone else, I want to avoid comment spam, any duplicate comments will be deleted.

Thanks for your patience folks, we're getting there slowly.

@MarshallOfSound
Copy link
Owner Author

4.7.1 has been released

@coreybruce
Copy link

Can you please tell me what you did to resolve this issue? I have my own Google Play music desktop application with the same insecure login message. It's confirmed as a issue for certain newer Google accounts that have never logged into a desktop application like these ones before as I have tested with a couple other accounts that have the issue but my main one doesn't have this issue and I can't figure out what the issue or difference is between the accounts.

Here is my gitlab repo: https://gitlab.com/google-play-music-desktop/application

@coreybruce
Copy link

Here is a screenshot of my main account logged in my Google Play music application with no issues.
https://i.imgur.com/undefined.png

And here is my other account having the insecure login issue in the same application
https://i.imgur.com/8bpY0Oq.png

@jostrander
Copy link
Collaborator

@coreybruce Check out the UA in this commit: a606518

@coreybruce
Copy link

I also have been fiddling with user agents but trying to fine the one that will work the best

@coreybruce
Copy link

coreybruce commented Jan 14, 2020

Thanks for the help @jostrander, I will try that out 👍

@coreybruce
Copy link

coreybruce commented Jan 14, 2020

Ok so I set my useragent code to this:
{ userAgent: "Mozilla/5.0 rv:73.0) Gecko/20100101 Firefox/73.0'"})

and now that account that I was using to test having the issue allowed me to login while I had phone login enabled. I am going to try and login again without phone login enabled and see if that still works.

-EDIT-

It works, I tested it with 2 different account that had the issue even with phone login not enabled and it let them log in without issues. This could be a solution guys! :D

@coreybruce
Copy link

coreybruce commented Jan 14, 2020

Here is a link to my main.js file as a reference
https://gitlab.com/google-play-music-desktop/application/blob/master/main.js

@giflw
Copy link

giflw commented Apr 27, 2020

Ok so I set my useragent code to this:
{ userAgent: "Mozilla/5.0 rv:73.0) Gecko/20100101 Firefox/73.0'"})

and now that account that I was using to test having the issue allowed me to login while I had phone login enabled. I am going to try and login again without phone login enabled and see if that still works.

-EDIT-

It works, I tested it with 2 different account that had the issue even with phone login not enabled and it let them log in without issues. This could be a solution guys! :D

I've changed this on Mellow Player settings and worked for me

@jostrander jostrander unpinned this issue Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet