Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRPI stops working after Discord restart #3404

Open
kythre opened this issue Oct 25, 2018 · 1 comment · Fixed by EnchantedLeaves/Google-Play-Music-Desktop-Player-UNOFFICIAL-#1 · May be fixed by #3785
Open

DRPI stops working after Discord restart #3404

kythre opened this issue Oct 25, 2018 · 1 comment · Fixed by EnchantedLeaves/Google-Play-Music-Desktop-Player-UNOFFICIAL-#1 · May be fixed by #3785
Labels

Comments

@kythre
Copy link

kythre commented Oct 25, 2018

OS:
Win10 1803 17134.345

GPMDP Version:
4.6.1

Issue Descriptions:
DRPI stops working after Discord restart
Requires GPMDP to be restarted for DRPI to work again

Steps to Reproduce:

  1. Start Discord
  2. Open GPMDP and Play song
  3. Restart Discord
  4. Observe

I think this can also be reprouced by putting the comptuer into sleep mode and waking it back up instead of restarting Discord

@welcome
Copy link

welcome bot commented Oct 25, 2018

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of duplicate issues on this repo, so please double check now that your issue has not already been solved or doesn't have an open issue already.
To help make it easier for us to investigate your issue, please follow the contributing guidelines and ensure the issue template was filled out.

Alipoodle added a commit to Alipoodle/Google-Play-Music-Desktop-Player-UNOFFICIAL- that referenced this issue Jan 26, 2020
Possible fix to MarshallOfSound#2969
This issue was caused by a dead RPC connection when Discord wasn't open, still trying to send requests to it.

Fixes MarshallOfSound#3266
This is fixed by using my own Discord application instead of the currently used one. I've previously requested to join the Team for the existing one but haven't got a reply. I have this one setup for teams already, and willing to add people if I'm provided with a Discord username + Discrim.

Fixes MarshallOfSound#3404
A connect + disconnect event were needed to be able to check if the client was actually connected and when to check for reconnections for this.

Looking through the Basic Discord-rich-presneces library used before, there was no event triggered for disconnecting from client.
This is why I have instead replace it with the native discord-rpc library instead of the wrapper library originally used, for better control over the RPC + all of the events including the Disconnect.

I've also added an additional feature of showing a Heart icon on songs which are liked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment