Use remote.origin.url on airflow integration test #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wslulciuc <[email protected]>
Signed-off-by: wslulciuc <[email protected]>
wslulciuc
commented
Feb 10, 2021
| @@ -20,8 +20,10 @@ set -e | |||
| project_root=$(git rev-parse --show-toplevel) | |||
| cd "${project_root}"/integrations/airflow/tests/integration | |||
|
|
|||
| REV=$(git rev-parse HEAD) | |||
| MARQUEZ_AIRFLOW_LIB_WITH_REV="git+git://github.com/MarquezProject/marquez.git@${REV}#egg=marquez_airflow&subdirectory=integrations/airflow" | |||
| GIT_URL=$(git config --get remote.origin.url \ | |||
There was a problem hiding this comment.
Note, we have to modify the link to use https, see pypa/pip#7554
Codecov Report
@@ Coverage Diff @@
## main #939 +/- ##
=========================================
Coverage 72.53% 72.53%
Complexity 830 830
=========================================
Files 167 167
Lines 3780 3780
Branches 360 360
=========================================
Hits 2742 2742
Misses 568 568
Partials 470 470 Continue to review full report at Codecov.
|
henneberger
approved these changes
Feb 10, 2021
mobuchowski
pushed a commit
that referenced
this pull request
Jul 27, 2021
* Use remote.origin.url on airflow integration test Signed-off-by: wslulciuc <[email protected]> * Fix git url for requirement.txt Signed-off-by: wslulciuc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (attempts) to fix the failed integration tests for forked PRs. The main issue is that, for forks, the commit is not associated with the marquez repo, see pull/894, which causes the
git checkoutcmd to fail when installing a lib from a git url, see the failing CI job 656We now dynamically build the url to point to
remote.origin.urland using the rev for that repo.