-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use remote.origin.url on airflow integration test #939
Conversation
Signed-off-by: wslulciuc <[email protected]>
Signed-off-by: wslulciuc <[email protected]>
@@ -20,8 +20,10 @@ set -e | |||
project_root=$(git rev-parse --show-toplevel) | |||
cd "${project_root}"/integrations/airflow/tests/integration | |||
|
|||
REV=$(git rev-parse HEAD) | |||
MARQUEZ_AIRFLOW_LIB_WITH_REV="git+git://github.com/MarquezProject/marquez.git@${REV}#egg=marquez_airflow&subdirectory=integrations/airflow" | |||
GIT_URL=$(git config --get remote.origin.url \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, we have to modify the link to use https
, see pypa/pip#7554
Codecov Report
@@ Coverage Diff @@
## main #939 +/- ##
=========================================
Coverage 72.53% 72.53%
Complexity 830 830
=========================================
Files 167 167
Lines 3780 3780
Branches 360 360
=========================================
Hits 2742 2742
Misses 568 568
Partials 470 470 Continue to review full report at Codecov.
|
* Use remote.origin.url on airflow integration test Signed-off-by: wslulciuc <[email protected]> * Fix git url for requirement.txt Signed-off-by: wslulciuc <[email protected]>
This PR (attempts) to fix the failed integration tests for forked PRs. The main issue is that, for forks, the commit is not associated with the marquez repo, see pull/894, which causes the
git checkout
cmd to fail when installing a lib from a git url, see the failing CI job 656We now dynamically build the url to point to
remote.origin.url
and using the rev for that repo.