Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove limit from assertion evaluation. #2844

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Remove limit from assertion evaluation. #2844

merged 2 commits into from
Jun 28, 2024

Conversation

phixMe
Copy link
Member

@phixMe phixMe commented Jun 27, 2024

Problem

There is a limit on the number of assertions we would process for some reason, giving us strange results that were not reflective of the full data set.

Closes: #2839

One-line summary: Fixes bug where our status indicator would be the wrong color.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added the web label Jun 27, 2024
Copy link

netlify bot commented Jun 27, 2024

Deploy Preview for peppy-sprite-186812 ready!

Name Link
🔨 Latest commit 19d36e0
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/667ee1cb6dcd210008dc202d
😎 Deploy Preview https://deploy-preview-2844--peppy-sprite-186812.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.56%. Comparing base (b5bcfbf) to head (20e3f50).

Current head 20e3f50 differs from pull request most recent head 19d36e0

Please upload reports for the commit 19d36e0 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2844      +/-   ##
============================================
- Coverage     84.74%   84.56%   -0.19%     
+ Complexity     1456     1441      -15     
============================================
  Files           253      251       -2     
  Lines          6562     6504      -58     
  Branches        305      303       -2     
============================================
- Hits           5561     5500      -61     
- Misses          850      851       +1     
- Partials        151      153       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wslulciuc wslulciuc added the bug Something isn't working label Jun 27, 2024
@wslulciuc wslulciuc added this to the 0.48.0 milestone Jun 27, 2024
@wslulciuc wslulciuc enabled auto-merge (squash) June 27, 2024 22:32
@wslulciuc wslulciuc merged commit 8010387 into main Jun 28, 2024
15 checks passed
@wslulciuc wslulciuc deleted the fix/remove-limit branch June 28, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working web
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Web UI - quality display
2 participants