Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customization of Apache HTTP in Java client #2822

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented May 24, 2024

Problem

MarquezClient uses the Apache HTTP client under the hood, and its defaults have some limitations around e.g. connection management. I'd like to be able to customize the client to my needs.

Solution

Add a builder method so you can provide a Consumer<HttpClientBuilder> allowing full customization of the Apache client without replicating its entire API on the Marquez side.

One-line summary: Allow customization of Apache HTTP in Java client

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Copy link

netlify bot commented May 24, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 2152f02
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/6658a200964d9d000840d90c

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.56%. Comparing base (b6057c3) to head (c2493f0).
Report is 1 commits behind head on main.

Current head c2493f0 differs from pull request most recent head 2152f02

Please upload reports for the commit 2152f02 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2822   +/-   ##
=========================================
  Coverage     84.55%   84.56%           
- Complexity     1440     1441    +1     
=========================================
  Files           251      251           
  Lines          6501     6504    +3     
  Branches        302      303    +1     
=========================================
+ Hits           5497     5500    +3     
  Misses          851      851           
  Partials        153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidjgoss davidjgoss force-pushed the feature/java-client-customise-http-client branch from 0380956 to d52ba48 Compare May 25, 2024 09:09
@davidjgoss davidjgoss changed the title Allow custom connection manager in Java client Allow customisation of apache http in Java client May 25, 2024
@davidjgoss davidjgoss changed the title Allow customisation of apache http in Java client Allow customisation of Apache HTTP in Java client May 25, 2024
@wslulciuc wslulciuc added this to the 0.48.0 milestone May 25, 2024
@davidjgoss davidjgoss force-pushed the feature/java-client-customise-http-client branch from d52ba48 to 89d39f7 Compare May 29, 2024 18:25
@davidjgoss davidjgoss changed the title Allow customisation of Apache HTTP in Java client Allow customization of Apache HTTP in Java client May 29, 2024
@davidjgoss davidjgoss force-pushed the feature/java-client-customise-http-client branch from 89d39f7 to c2493f0 Compare May 29, 2024 21:48
@wslulciuc wslulciuc merged commit e54ffca into MarquezProject:main May 30, 2024
2 of 6 checks passed
@davidjgoss davidjgoss deleted the feature/java-client-customise-http-client branch May 30, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants