-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Column Lineage Linking and sticky tab titles #2805
Conversation
✅ Deploy Preview for peppy-sprite-186812 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2805 +/- ##
=========================================
Coverage 84.47% 84.47%
Complexity 1429 1429
=========================================
Files 251 251
Lines 6460 6460
Branches 299 299
=========================================
Hits 5457 5457
Misses 850 850
Partials 153 153 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
…o feature/column-lineage-link
@davidsharp7 Good find on the description, I have rectified that display. I think we should modify the back button on the column lineage page to navigate back to the original dataset, or include a link to view the table lineage upon that page. But we'll tackle in another work stream. |
Cool - yeah agree that's a good plan of attack and we can look at it later. |
Problem
Previously, we had a column lineage link at the top of the dataset. Now that has been moved to the column level and therefore will link to the column directly if available.
Also pegs the titles of jobs and datasets to the top of the drawer as an enhancement to keep context in focus for users of Marquez.
One-line summary: Sticky Titles and column lineage links in the table definition.
Checklist
CHANGELOG.md
(Depending on the change, this may not be necessary)..sql
database schema migration according to Flyway's naming convention (if relevant)