Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column Lineage Linking and sticky tab titles #2805

Merged
merged 8 commits into from
May 1, 2024

Conversation

phixMe
Copy link
Member

@phixMe phixMe commented Apr 29, 2024

Problem

Previously, we had a column lineage link at the top of the dataset. Now that has been moved to the column level and therefore will link to the column directly if available.

Also pegs the titles of jobs and datasets to the top of the drawer as an enhancement to keep context in focus for users of Marquez.

One-line summary: Sticky Titles and column lineage links in the table definition.

image

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added the web label Apr 29, 2024
Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit a346b73
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/66329eb316ee2500080054e7

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.47%. Comparing base (ec2cf88) to head (a346b73).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2805   +/-   ##
=========================================
  Coverage     84.47%   84.47%           
  Complexity     1429     1429           
=========================================
  Files           251      251           
  Lines          6460     6460           
  Branches        299      299           
=========================================
  Hits           5457     5457           
  Misses          850      850           
  Partials        153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phixMe phixMe requested a review from davidsharp7 April 30, 2024 18:21
@phixMe phixMe requested a review from wslulciuc April 30, 2024 20:38
Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@wslulciuc wslulciuc enabled auto-merge (squash) April 30, 2024 20:50
@davidsharp7
Copy link
Member

davidsharp7 commented May 1, 2024

I like this. Couple of seriously minor comments

Do we want to be able to navigate back from the column lineage view to the dataset view i.e where you came from?

The dataset description seems rammed up against the border line. The spacing just looks a little off. It might be fine if the dataset name was closer to the description.

Screenshot 2024-05-01 at 19 45 17

@phixMe phixMe disabled auto-merge May 1, 2024 18:46
@phixMe
Copy link
Member Author

phixMe commented May 1, 2024

@davidsharp7 Good find on the description, I have rectified that display.

I think we should modify the back button on the column lineage page to navigate back to the original dataset, or include a link to view the table lineage upon that page. But we'll tackle in another work stream.

@davidsharp7
Copy link
Member

Cool - yeah agree that's a good plan of attack and we can look at it later.

@phixMe phixMe merged commit 6576fb3 into main May 1, 2024
16 checks passed
@phixMe phixMe deleted the feature/column-lineage-link branch May 1, 2024 20:26
@wslulciuc wslulciuc added the v2.UI label May 7, 2024
@wslulciuc wslulciuc added this to the 0.47.0 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants