Minor UI enhancements #2727
Merged
Minor UI enhancements #2727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 22 commits
December 7, 2023 16:56
# Conflicts: # web/src/components/datasets/DatasetDetailPage.tsx # web/src/store/sagas/index.ts
✅ Deploy Preview for peppy-sprite-186812 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2727 +/- ##
=========================================
Coverage 84.45% 84.45%
Complexity 1416 1416
=========================================
Files 251 251
Lines 6447 6447
Branches 291 291
=========================================
Hits 5445 5445
Misses 850 850
Partials 152 152 ☔ View full report in Codecov by Sentry. |
|
"minor" changes for 8000 lines? 😮 |
|
This is just on top of #2725, so it's minor after that. |
7 tasks
added 4 commits
February 9, 2024 15:19
# Conflicts: # web/src/components/datasets/DatasetDetailPage.tsx # web/src/routes/column-level/ColumnLevel.tsx # web/src/routes/column-level/ColumnLevelDrawer.tsx # web/src/routes/column-level/ColumnLineageColumnNode.tsx # web/src/routes/column-level/layout.ts # web/src/routes/datasets/Datasets.tsx # web/src/routes/table-level/ActionBar.tsx # web/src/routes/table-level/TableLevel.tsx # web/src/routes/table-level/TableLineageDatasetNode.tsx # web/src/routes/table-level/TableLineageJobNode.tsx # web/src/routes/table-level/layout.ts
Fixed edge to non-existent node issue. .
# Conflicts: # web/src/components/datasets/DatasetInfo.tsx # web/src/components/datasets/DatasetTags.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This is a followup to the larger lineage update PR #2725 that fixes some minor application consistency and styling issues.
Solution
One-line summary: Hygienic cleanup of project
Checklist
CHANGELOG.md(Depending on the change, this may not be necessary)..sqldatabase schema migration according to Flyway's naming convention (if relevant)