remove maven-archiver dependency from java client #2695
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Java client has a dependency on
maven-archiver
, which can bring some transitive vulnerabilities.This is a build tool only though and shouldn't go through as a transitive dependency to consumers of the client. Further, I can't see why it's needed - the
api
module doesn't have it, and if I remove it and do a build and publish to my local Maven repo, it works fine.Solution
Remove the dependency from
build.gradle
.If I'm wrong and this is needed, we could look instead at adding the dependency to
publishing
orbuildScript
to avoid consumers getting it unnecessarily.One-line summary:
remove maven-archiver dependency from java client
Checklist
CHANGELOG.md
(Depending on the change, this may not be necessary)..sql
database schema migration according to Flyway's naming convention (if relevant)