Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web/add dataset drawer #2672

Merged
merged 10 commits into from
Nov 29, 2023
Merged

Conversation

davidsharp7
Copy link
Member

@davidsharp7 davidsharp7 commented Oct 30, 2023

Problem

An idea to move some column level attributes to a side drawer to make better use of screen real estate and with a view of adding additional column level information.

Screenshot 2023-10-30 at 13 29 41

Solution

Add a drawer which displays column level information (tags at the moment) on the right hand of the screen when a column is selected. Use an accordion to allow hide/expand data elements.

One-line summary:

Add drawer to dataset column view.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added the web label Oct 30, 2023
@netlify
Copy link

netlify bot commented Oct 30, 2023

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 45120ec
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/656782b49b5cdd000824b719

@davidsharp7
Copy link
Member Author

@phixMe @wslulciuc - this is what I was talking about. It's a bit of hack but you get the idea.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d578a3f) 84.08% compared to head (45120ec) 84.08%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2672   +/-   ##
=========================================
  Coverage     84.08%   84.08%           
  Complexity     1379     1379           
=========================================
  Files           248      248           
  Lines          6295     6295           
  Branches        286      286           
=========================================
  Hits           5293     5293           
  Misses          849      849           
  Partials        153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidsharp7 davidsharp7 marked this pull request as ready for review November 18, 2023 02:50
@davidsharp7 davidsharp7 marked this pull request as draft November 18, 2023 02:53
@davidsharp7 davidsharp7 marked this pull request as ready for review November 23, 2023 06:30
elevation={0}
anchor='right'
open={open}
onClose={handleClose}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only used in one place, so you shouldn't need a wrapper function.

anchor='right'
open={open}
onClose={handleClose}
sx={{ zIndex: 1300 }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you reference a variable for this in the theme?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah cool will move this out.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool will fix this up.

Copy link
Member

@phixMe phixMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidsharp7

@phixMe phixMe merged commit bdd42bf into MarquezProject:main Nov 29, 2023
16 checks passed
yanlibert pushed a commit to libertyann/marquez that referenced this pull request Dec 7, 2023
* add drawer to Dataset info on click

Signed-off-by: sharpd <[email protected]>

* update drawer formatting/revert chips to row

Signed-off-by: sharpd <[email protected]>

* fix logic errors in description

Signed-off-by: sharpd <[email protected]>

* add icon fo visual drawer cue

Signed-off-by: sharpd <[email protected]>

* update code based on feedback. Refer to theme values remove function.

Signed-off-by: sharpd <[email protected]>

---------

Signed-off-by: sharpd <[email protected]>
Co-authored-by: sharpd <[email protected]>
Signed-off-by: yanlibert <[email protected]>
yanlibert pushed a commit to libertyann/marquez that referenced this pull request Dec 8, 2023
* add drawer to Dataset info on click

Signed-off-by: sharpd <[email protected]>

* update drawer formatting/revert chips to row

Signed-off-by: sharpd <[email protected]>

* fix logic errors in description

Signed-off-by: sharpd <[email protected]>

* add icon fo visual drawer cue

Signed-off-by: sharpd <[email protected]>

* update code based on feedback. Refer to theme values remove function.

Signed-off-by: sharpd <[email protected]>

---------

Signed-off-by: sharpd <[email protected]>
Co-authored-by: sharpd <[email protected]>
@wslulciuc wslulciuc added this to the 0.43.0 milestone Dec 13, 2023
@davidsharp7 davidsharp7 deleted the web/add_dataset_drawer branch December 31, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants