Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct example syntax for java client readme #2575

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Aug 9, 2023

Problem

Errant parens in the example code makes it invalid - builder is a static method.

Solution

Remove the parens so the example is correct and matches the later one in the file.

One-line summary:
Correct example syntax for Java client README

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg
Copy link

boring-cyborg bot commented Aug 9, 2023

Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md).

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #2575 (dbca1da) into main (afd8adc) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2575   +/-   ##
=========================================
  Coverage     83.26%   83.26%           
  Complexity     1286     1286           
=========================================
  Files           243      243           
  Lines          5934     5934           
  Branches        279      279           
=========================================
  Hits           4941     4941           
  Misses          846      846           
  Partials        147      147           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh nice catch! 💯

@wslulciuc wslulciuc merged commit 55b55bf into MarquezProject:main Aug 9, 2023
3 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 9, 2023

Great job! Congrats on your first merged pull request in the Marquez project!

@davidjgoss davidjgoss deleted the davidjgoss-patch-1 branch August 9, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants