Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update web proxy import #2571

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Update web proxy import #2571

merged 1 commit into from
Aug 7, 2023

Conversation

phixMe
Copy link
Member

@phixMe phixMe commented Aug 7, 2023

Problem

Our ./docker/up.sh process is currently broken due to the fact that http-proxy-middleware was upgraded.

One-line summary:
Updating the import style for the http-proxy-middleware

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added the web label Aug 7, 2023
@phixMe phixMe requested a review from wslulciuc August 7, 2023 18:53
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #2571 (3b6cb43) into main (6a512a1) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2571   +/-   ##
=========================================
  Coverage     83.26%   83.26%           
  Complexity     1286     1286           
=========================================
  Files           243      243           
  Lines          5934     5934           
  Branches        279      279           
=========================================
  Hits           4941     4941           
  Misses          846      846           
  Partials        147      147           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, @phixMe 👍

@wslulciuc wslulciuc merged commit 1d46b66 into main Aug 7, 2023
3 checks passed
@wslulciuc wslulciuc deleted the fix/web-proxy branch August 7, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants