-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert URL encoding when fetching lineage #2529
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2529 +/- ##
=========================================
Coverage 83.80% 83.80%
Complexity 1233 1233
=========================================
Files 235 235
Lines 5625 5625
Branches 270 270
=========================================
Hits 4714 4714
Misses 767 767
Partials 144 144 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: John Lukenoff <[email protected]>
Signed-off-by: John Lukenoff <[email protected]>
jlukenoff
force-pushed
the
web/fix-encoded-nodeid
branch
from
June 28, 2023 15:42
b42cc11
to
715148c
Compare
Signed-off-by: John Lukenoff <[email protected]>
jlukenoff
changed the title
Revert URL encoding
Revert URL encoding when fetching lineage
Jun 28, 2023
phixMe
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jlukenoff for this and the test!
Xavier-Cliquennois
pushed a commit
to Xavier-Cliquennois/marquez
that referenced
this pull request
Jul 5, 2023
* Revert URL encoding Signed-off-by: John Lukenoff <[email protected]> * comment Signed-off-by: John Lukenoff <[email protected]> * Add a test Signed-off-by: John Lukenoff <[email protected]> --------- Signed-off-by: John Lukenoff <[email protected]>
Xavier-Cliquennois
pushed a commit
to Xavier-Cliquennois/marquez
that referenced
this pull request
Jul 6, 2023
* Revert URL encoding Signed-off-by: John Lukenoff <[email protected]> * comment Signed-off-by: John Lukenoff <[email protected]> * Add a test Signed-off-by: John Lukenoff <[email protected]> --------- Signed-off-by: John Lukenoff <[email protected]> Signed-off-by: Xavier-Cliquennois <[email protected]>
Xavier-Cliquennois
pushed a commit
to Xavier-Cliquennois/marquez
that referenced
this pull request
Jul 6, 2023
* Revert URL encoding Signed-off-by: John Lukenoff <[email protected]> * comment Signed-off-by: John Lukenoff <[email protected]> * Add a test Signed-off-by: John Lukenoff <[email protected]> --------- Signed-off-by: John Lukenoff <[email protected]>
Xavier-Cliquennois
pushed a commit
to Xavier-Cliquennois/marquez
that referenced
this pull request
Jul 26, 2023
* Revert URL encoding Signed-off-by: John Lukenoff <[email protected]> * comment Signed-off-by: John Lukenoff <[email protected]> * Add a test Signed-off-by: John Lukenoff <[email protected]> --------- Signed-off-by: John Lukenoff <[email protected]> Signed-off-by: Xavier-Cliquennois <[email protected]> Signed-off-by: Xavier-Cliquennois <[email protected]>
Xavier-Cliquennois
pushed a commit
to Xavier-Cliquennois/marquez
that referenced
this pull request
Jul 26, 2023
* Revert URL encoding Signed-off-by: John Lukenoff <[email protected]> * comment Signed-off-by: John Lukenoff <[email protected]> * Add a test Signed-off-by: John Lukenoff <[email protected]> --------- Signed-off-by: John Lukenoff <[email protected]> Signed-off-by: Xavier-Cliquennois <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When I converted this to use the URLSearchParams in #2525, we started inadvertently url-encoding the node id, which causes problems if the node id contains special characters.
Solution
This reverts node ID from being URL encoded and allows the backend to successfully return the lineage details even when the node ID contains special characters.
Checklist
CHANGELOG.md
(Depending on the change, this may not be necessary)..sql
database schema migration according to Flyway's naming convention (if relevant)