Soft delete of jobs and datasets. Style dialog component #2343
Conversation
Signed-off-by: tito12 <[email protected]>
|
A much needed addition to the UI! Looks great, we should also added deletion of namespaces as a follow up feature. I'll let @phixMe provide a more thorough review. |
web/src/components/Dialog.tsx
Outdated
| @@ -26,16 +27,28 @@ export default function AlertDialog(props: IProps) { | |||
| <div> | |||
There was a problem hiding this comment.
Do we need to have this encapsulating tag?
There was a problem hiding this comment.
This component exist previously with encapsulating tag. Moved it to functional component as rest part components.
| }, | ||
| buttonDelete: { | ||
| backgroundColor: theme.palette.error.main, | ||
| color: 'white', |
There was a problem hiding this comment.
I think I like doing the theme.palette.common.white for these in case we ever wish to support light mode.
| > | ||
| {i18next.t('jobs.delete')} | ||
| </Button> | ||
| <Dialog |
There was a problem hiding this comment.
There are two instances of this dialog... Can the dialog itself just be a reusable component.
There was a problem hiding this comment.
This component is reusable and located in "components/Dialog.tsx", and use it with different props
| <Box display={'flex'} alignItems={'center'}> | ||
| <Box mr={1}> | ||
| <Button | ||
| color='primary' |
There was a problem hiding this comment.
Can we make this a ghost variant... I think it's a little too strong on the page.
web/src/components/Dialog.tsx
Outdated
| onClick={props.ignoreWarning} | ||
| > | ||
| Continue | ||
| </Button> |
There was a problem hiding this comment.
Can we make these small buttons inside the dialog?
There was a problem hiding this comment.
Sorry, can you explain what do you mean by that?
There was a problem hiding this comment.
I think we could possibly use smaller buttons here since the dialog is so minute, but maybe it's not necessary.
Signed-off-by: tito12 <[email protected]>
Signed-off-by: tito12 <[email protected]>
Signed-off-by: tito12 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2343 +/- ##
============================================
+ Coverage 67.15% 76.72% +9.56%
- Complexity 231 1177 +946
============================================
Files 40 222 +182
Lines 947 5354 +4407
Branches 101 429 +328
============================================
+ Hits 636 4108 +3472
- Misses 163 768 +605
- Partials 148 478 +330
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: tito12 <[email protected]>
Signed-off-by: tito12 <[email protected]>
Signed-off-by: tito12 <[email protected]>
Signed-off-by: tito12 [email protected]
Problem
According to the issue #2167 we need option to soft delete records, it's already possible from API but not from UI.
Solution
Added option for jobs and datasets to be able to soft delete record with dialog component and double confirmation from UI side.
Checklist
CHANGELOG.mdwith details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sqldatabase schema migration according to Flyway's naming convention (if relevant)