Show facets even when dataset has no fields.

Signed-off-by: Jakub Dardzinski <[email protected]>
MarquezProject · Oct 26, 2022 · 857b87e · 857b87e
1 parent db92c4f
commit 857b87e
Showing 1 changed file with 33 additions and 27 deletions.
diff --git a/web/src/components/datasets/DatasetInfo.tsx b/web/src/components/datasets/DatasetInfo.tsx
@@ -21,38 +21,44 @@ interface DatasetInfoProps {
 const DatasetInfo: FunctionComponent<DatasetInfoProps> = props => {
   const { datasetFields, facets, run } = props
 
+  let datasetFieldsBox;
+
+
   if (datasetFields.length === 0) {
-    return <MqEmpty title={'No Fields'} body={'Try adding dataset fields.'} />
+    datasetFieldsBox = <MqEmpty title={'No Fields'} body={'Try adding dataset fields.'} />
+  }
+  else {
+    datasetFieldsBox = <Table size='small'>
+    <TableHead>
+      <TableRow>
+        {DATASET_COLUMNS.map(column => {
+          return (
+            <TableCell key={column} align='left'>
+              <MqText subheading inline>
+                {column}
+              </MqText>
+            </TableCell>
+          )
+        })}
+      </TableRow>
+    </TableHead>
+    <TableBody>
+      {datasetFields.map(field => {
+        return (
+          <TableRow key={field.name}>
+            <TableCell align='left'>{field.name}</TableCell>
+            <TableCell align='left'>{field.type}</TableCell>
+            <TableCell align='left'>{field.description || 'no description'}</TableCell>
+          </TableRow>
+        )
+      })}
+    </TableBody>
+  </Table>
   }
 
   return (
     <Box>
-      <Table size='small'>
-        <TableHead>
-          <TableRow>
-            {DATASET_COLUMNS.map(column => {
-              return (
-                <TableCell key={column} align='left'>
-                  <MqText subheading inline>
-                    {column}
-                  </MqText>
-                </TableCell>
-              )
-            })}
-          </TableRow>
-        </TableHead>
-        <TableBody>
-          {datasetFields.map(field => {
-            return (
-              <TableRow key={field.name}>
-                <TableCell align='left'>{field.name}</TableCell>
-                <TableCell align='left'>{field.type}</TableCell>
-                <TableCell align='left'>{field.description || 'no description'}</TableCell>
-              </TableRow>
-            )
-          })}
-        </TableBody>
-      </Table>
+      {datasetFieldsBox}
       {facets && (
         <Box mt={2}>
           <Box mb={1}>