Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for hosting website via nginx docker #153

Merged
merged 12 commits into from
Oct 11, 2023
Merged

Added support for hosting website via nginx docker #153

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c5e869f
[MarmadileManteater] Dockerfile, changed node_modules to dist/web
OwenTruong Jul 1, 2023
86c240f
Update Dockerfile
MarmadileManteater Jul 13, 2023
b9fc9ab
Merge branch 'MarmadileManteater:development' into dockerize
OwenTruong Aug 21, 2023
e5c56cf
No conditional copy allowed in Docker so "COPY dist[t]/web ./dist/" w…
OwenTruong Aug 21, 2023
7300fec
removed unnecessary condition in run instruction and copying of /app/…
OwenTruong Aug 21, 2023
26a0d8a
moved comment up a line
OwenTruong Aug 21, 2023
be2aea2
removed unnecessary conditionals in build stage yarn pack:web
OwenTruong Aug 21, 2023
6bbf92b
reverted changes from August 21st that removed the conditional copy a…
OwenTruong Aug 31, 2023
a81dc7d
changed warning on local docker build to be Apple Silicon specific
OwenTruong Aug 31, 2023
9e31c77
pulled new changes from development branch into dockerize branch, and…
OwenTruong Aug 31, 2023
e2321e5
Merge branch 'development' into dockerize
OwenTruong Sep 2, 2023
20269ff
Copying host's dist/web to container's dist/web instead of dist/
OwenTruong Sep 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,10 @@ COPY package.json ./package.json
COPY yarn.lock ./yarn.lock
OwenTruong marked this conversation as resolved.
Show resolved Hide resolved
# copy `dist` if it exists already
COPY dis[t]/web ./dist/
OwenTruong marked this conversation as resolved.
Show resolved Hide resolved
COPY node_module[s] ./node_modules
# git is needed for jinter
RUN apk add git
# don't rebuild if you don't have to
RUN if [ ! -d 'node_modules' ]; then yarn ci; fi
RUN if [ ! -d 'dist/web' ]; then yarn ci; fi

## Build Stage ##
FROM node:18-alpine AS build
Expand Down
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,9 @@ yarn pack:web

### Commands for the PWA Docker Image
```bash

# 💨 Creates and runs the image locally. Add `--platform=linux/arm64` to docker build for ARM64 devices including Apple Silicon
docker build -t freetubecordova . # Warning, might take 10 minutes.
docker build -t freetubecordova . # Warning, might take a while on Apple Silicon
docker run --name ftcordova -d -p 8080:80 freetubecordova

# 🏃 Runs the image from Docker Hub.
Expand Down