[Feature Request]: Implement UI Scale on android

[ChaosFenix]

Guidelines

• I have encountered this bug in the latest release of FreeTube.
• I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
• I have searched the documentation for information that matches the description of the bug I want to file, without success.
• This issue contains only one bug.

Describe the bug

In the Settings go to UI Scale and adjust the Scale to anything but 100%. It doesn't actually change anything.

Expected Behavior

I would expect UI elements to shrink and expand as the scale was Adjusted.

Issue Labels

inconsistent behavior, usability issue

FreeTube Version

v.22.0.126 Beta

Operating System Version

Android

Installation Method

.apk

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

I was trying to make the videos more dense in a list. I don't like that I can only see 2 videos at a time on my screen. I switched to list view on the videos which indeed shrinks the thumbnail but the text still takes up a ton of space. I then tried chaning the UI scale to be more dense. When adjusting it though I found that it doesn't actually do anything on the android application. I have verified that it does in fact make the UI more dense on the desktop application.

Nightly Build

• I have encountered this bug in the latest nightly build.

[absidue]

Thank you for pointing this out. The actual bug is that that option shows up outside of the upstream Electron version, as is is only meant to exist in the upstream Electron build.

I'll create a pull request upstream to remove the setting in the non-Electron builds.

[MarmadileManteater]

I am treating this as a feature request and just going ahead and implementing it.

[MarmadileManteater]

The nightly should now have a working UI scale setting: https://github.com/MarmadileManteater/FreeTubeAndroid/actions/runs/12681331587

[ChaosFenix]

Verified that scaling does indeed work in the nightly build. Thanks for fixing it. If this is a feature request now do you know if it would be possible to get even higher density on the videos? With 50% scaling you go from 1.8 thumbnails at a time to almost 4. If you switch to list you can get almost 5. Ideally I would like closer to 7 which is what you can get on newpipe. I feel we could get there by tweaking a few things. I noticed in list view it shows the video discription which takes up quite a bit of real estate. This should probably be hidden like it is when in grid view. I even tried going into the distraction free settings and chosing to hide it. It does it frome the player view but not in the list view when you are looking at thumbnails. I think if we removed the video description and made list view the default as well as put scaling at like 65% by default it would make for a really good experience.

[MarmadileManteater]

I am not considering changing the default setting at the moment. As far as the list view description is concerned, I don't have any interest in changing that to be different from upstream, sorry 😔. But, I can make the setting allow for even higher density.

[anuragtyagi-dev]

Thank you for this.

[MarmadileManteater]

ok, so I just casually saw this change on my bfs phone, and it made me realise the way I'm scaling the viewport doesn't seem to work the same on all devices, so I need to investigate that.

[cyberwolfie1]

I just updated from nightly 504 to 532, and UI-scaling is acting really weird for me. By default, settings is not reachable in portrait mode, and I need to scale down to 75% for it to be visible (can access settings through landscape mode). Then I need to pinch-zoom out on previous pages to "apply" these settings.

An additional point to the UI-scaling that would be nice from my use case: I sync my settings with the desktop version (although I still have the issue with it not loading until I reset the data directory). The one running on my media computer hooked up to my TV runs at 150% UI-scale. Would it at all be possible to disconnect the two? E.g. having the UI-scale on Android control a different setting than the desktop version so they could both be set individually?

[MarmadileManteater]

I added a setting for enabling/disabling ui scale for the moment until I can identify how to make it work the same on most devices.

[MarmadileManteater]

I changed the setting name for uiScale used on android. This should mean that the setting should never sync between android and desktop.