Fix LCD prepare menu when heating #5658
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When heating prepare menu is clean, break it is error.
Blue-Marlin
reviewed
Jan 4, 2017
| @@ -1403,7 +1403,7 @@ void kill_screen(const char* lcd_msg) { | |||
| // Cooldown | |||
| // | |||
| bool has_heat = false; | |||
| HOTEND_LOOP() if (thermalManager.target_temperature[e]) { has_heat = true; break; } | |||
| HOTEND_LOOP() if (thermalManager.target_temperature[e]) has_heat = true; | |||
| #if HAS_TEMP_BED | |||
There was a problem hiding this comment.
The problem is HOTEND_LOOP is not always a loop
#if HOTENDS == 1
#define HOTEND_LOOP() const int8_t e = 0;
#define HOTEND_INDEX 0
#define EXTRUDER_IDX 0
#else
#define HOTEND_LOOP() for (int8_t e = 0; e < HOTENDS; e++)
#define HOTEND_INDEX e
#define EXTRUDER_IDX active_extruder
#endif
|
edit deleted |
|
Sorry i did not see that! |
Not a problem! I was going to hunt down and post that issue so you would have confirmation that your fix worked. But I ran out of time yesterday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When iheat the hotend or preheat PLA, ABS or temperature control the prepare menu becomes empty.
I deleted the break and now it works perfectly.
It seems to me as strange thing, but for some reason the break not only comes from the HOTEND_LOOP, but the routine itself.
Sorry for english!