Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to homing / leveling #4651

Merged
merged 13 commits into from
Aug 19, 2016

Conversation

thinkyhead
Copy link
Member

@thinkyhead thinkyhead commented Aug 19, 2016

See individual commits for a summary of each. Basically…

Bugs:

  • Fix instances where LOGICAL_Z_POSITION should be applied to a "raw" position.
  • Make sure to set the software endstops when EEPROM loaded or defaults restored.
  • Account for the probe Z offset when doing pre-probe move "close to the bed."

Adjustments:

  • Consolidate repeated probing code into a function.
  • Apply suggested fix to xSpacing / ySpacing to get better probe points.

References: #4577, #4220, #4520, #4644

@thinkyhead thinkyhead force-pushed the rc_homing_vs_leveling_z branch from 9dc3090 to 391eb38 Compare August 19, 2016 09:33
@thinkyhead thinkyhead force-pushed the rc_homing_vs_leveling_z branch from 391eb38 to 044f800 Compare August 19, 2016 09:45
@Roxy-3D
Copy link
Member

Roxy-3D commented Aug 19, 2016

Do we know if this fixes (or at least helps) the Z-Offset issues we have been hearing about? If so... I need to cross these changes over to the UBL code base.

@thinkyhead
Copy link
Member Author

thinkyhead commented Aug 19, 2016

We will receive confirmation (or not) pretty soon.
Either way, the bug-fix changes here are definitely needed.

@thinkyhead thinkyhead merged commit 4d4c00d into MarlinFirmware:RCBugFix Aug 19, 2016
@thinkyhead thinkyhead deleted the rc_homing_vs_leveling_z branch August 19, 2016 20:45
@thinkyhead thinkyhead mentioned this pull request Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants