Delta Forward Kinematics (and LOGICAL_POSITION) #4370
Merged
+189
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
force-pushed
the
rc_delta_fwd_kinematics
branch
2 times, most recently
from
a151ee0
to
a13f6b0
Compare
thinkyhead
force-pushed
the
rc_delta_fwd_kinematics
branch
2 times, most recently
from
016c7c4
to
fe8bc5c
Compare
thinkyhead
force-pushed
the
rc_delta_fwd_kinematics
branch
from
fe8bc5c
to
b6afa02
Compare
|
Another place where we need to consider the Adding code for that now… b3eb0c8 |
thinkyhead
force-pushed
the
rc_delta_fwd_kinematics
branch
3 times, most recently
from
33fc730
to
6dda18c
Compare
thinkyhead
force-pushed
the
rc_delta_fwd_kinematics
branch
from
6dda18c
to
b3eb0c8
Compare
thinkyhead
changed the title
thinkyhead
force-pushed
the
rc_delta_fwd_kinematics
branch
from
fa58bd6
to
6b8b458
Compare
|
I've tested just now, but results of G28 and G29 of DELTA has been exactly same as Yesterday's report again, unfortunately. Commands:
|
|
I remark that it's by seeing the log. At first, Second, Z coordinate of |
|
I'm adding more logging! I'll merge the PR within the next few minutes… |
|
👍 Congratulations. |
|
I got compilation warnings.
|
AnHardt
added a commit
to AnHardt/Marlin
that referenced
this pull request
Jul 23, 2016
thinkyhead
pushed a commit
to thinkyhead/Marlin
that referenced
this pull request
Jul 23, 2016
This was referenced Jul 23, 2016
Closed
CONSULitAS
pushed a commit
to CONSULitAS/Marlin-K8200
that referenced
this pull request
Aug 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derived from AnHardt#60
Background: Up to now, if you wanted to get the "current position" of a 3D printer based on the stepper positions, you could only do so on Cartesian, Core, and SCARA. We didn't have that for Delta. So when probing, we generally just looked at the distance traveled to figure out where Z ended up. And after a "quick stop" where the steppers were interrupted, there was no way to recover the current position from a Delta.
Considerations: Whenever we use "sub-systems" that rely on an idealized coordinate system (MBL, kinematics, etc.), we need to subtract the coordinate space offsets before using the coordinates. Otherwise
M206andG92will cause havoc.Solutions:
set_current_from_steppersfunction that works for all kinematics.LOGICAL_POSITIONwhere needed to add offsets to coordinates.RAW_POSITIONwhere needed to remove offsets from coordinates.Additional changes:
DELTA-specific declarations inMarlin_main.cpp.adjust_deltawithSCARA(compile errors).SCARAwith ABL.Z_MIN_PROBE_REPEATABILITY_TEST.