Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENDSTOPS_ONLY_FOR_HOMING is confusing #4306

Merged
merged 5 commits into from
Jul 17, 2016
Merged

ENDSTOPS_ONLY_FOR_HOMING is confusing #4306

merged 5 commits into from
Jul 17, 2016

Conversation

thinkyhead
Copy link
Member

@thinkyhead thinkyhead commented Jul 14, 2016 •
edited
Loading

The function of this option is not clear.

"If I enable this, endstops will only be used for homing."

In fact, this behavior is altered by M120 and M121, so this really just sets the default state at boot-up.

Instead, let's try…

"If I enable this, endstops are 'always on' by default."

  • Replace ENDSTOPS_ONLY_FOR_HOMING with ENDSTOPS_ALWAYS_ON_DEFAULT
  • Use this setting as the "factory default" in M502

@thinkyhead thinkyhead mentioned this pull request Jul 15, 2016
Closed
@thinkyhead thinkyhead merged commit 253f843 into MarlinFirmware:RCBugFix Jul 17, 2016
@thinkyhead thinkyhead deleted the rc_stupid_name_okbai branch July 17, 2016 20:50
@jbrazio jbrazio modified the milestone: 1.1.0 Jul 18, 2016
@AnHardt AnHardt mentioned this pull request Jul 19, 2016
Merged
@thinkyhead thinkyhead mentioned this pull request Jul 25, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Configurations PR: Improvement
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@thinkyhead @jbrazio