Adjust wait_for_cooling slope #4250
Merged
+22
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Overall it looks good. Do we need to increase one of our vars here to |
| if (old_temp - temp < 1.0) break; | ||
| next_cool_check_ms = now + 20000; | ||
| if (old_temp - temp < MIN_COOLING_SLOPE_DEG_BED) break; | ||
| next_cool_check_ms = now + 1000UL * MIN_COOLING_SLOPE_TIME_BED; |
There was a problem hiding this comment.
@thinkyhead
No, not a variable. Just a constant. For some reason 1000UL * MIN_COOLING_SLOPE_TIME_BED is done in int if we don't us UL. Worked great for times up to 32 seconds, but not for 60.
AnHardt
force-pushed
the
wait-for-cooling-slope
branch
3 times, most recently
from
1afc055
to
e92e58d
Compare
Adjust wait_for_cooling slope and drop mintemp for cooling. See MarlinFirmware#4169 (comment)
Closed
drewmoseley
pushed a commit
to drewmoseley/Marlin
that referenced
this pull request
Nov 8, 2023
…HF_60W Add REVO High Flow 60W variant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust wait_for_cooling slope
and drop mintemp for cooling.
See
#4169 (comment)