-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce safe_delay() #4043
Introduce safe_delay() #4043
Conversation
Likely this is useful enough to give it a more prominent place. Marlin_main.cpp? temperature.cpp? |
@@ -443,6 +443,15 @@ unsigned lcd_print(char c) { return charset_mapper(c); } | |||
lcd.setCursor(indent, 2); lcd.print('\x02'); lcd_printPGM(PSTR( "------" )); lcd.print('\x03'); | |||
} | |||
|
|||
void save_delay(uint16_t del){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you mean "safe_delay
."
7fda58c
to
cec1b16
Compare
Thanks for the trying to fix. A branch that it was used for this test: |
@esenapaj |
Introduce save_delay() for long delays what otherwise would cause watchdog resets Explizit lcd_set_custom_characters(false) at the end of bootscreen(). Else the charset is not proper set in case of LCD_PROGRESS_BAR.
I can reproduce the problem occasionally. What we see is the upper half of the 'bed symbol' at the place the '°' should be. I have no idea how that can be. |
I have always seen custom character issues on the first boot. It fixes itself if you re-display the Info Screen. Maybe the custom character code is running early, when the display isn't ready. |
…aded_timeout MK3: Set `Is filament loaded? Yes|No` default to `No` without a timeout.
Introduce safe_delay() for long delays what otherwise would cause
watchdog resets. Especially when added.
Explizit
lcd_set_custom_characters(false)
at the end ofbootscreen()
.Else the charset is not proper set in case of
LCD_PROGRESS_BAR
.Follow up for #4032