-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Danish language pack #3932
Conversation
@boelle please use more descriptive commit messages like "Update Danish language pack" or "Initial update of the Danish language pack". Titles we can change/edit but commit messages we cannot. |
Well, we can edit commit messages, but we have to make a copy of the branch and submit a new PR to do it. |
@boelle The Germans did a lot of work, and quite a challenge it was, to reduce string lengths to 18 characters or less, with the most important part of the strings in the first 16 characters, as this is the minimum width of the screen. Ideally, we want to make these LCD display strings 16 characters at the most. Strings over 20 characters are a complete waste, as we will never display the additional characters (at least not until all LCD messages are scrolling). Characters past 20 are just wasted bytes, so you might as well cut the strings off at 20. |
Yikes! More CPU cycles to scroll! At least the Full Graphics Panels won't Seriously.... This is yet another example why we need to get the 32-Bit On Tue, May 31, 2016 at 8:23 PM, Scott Lahteine [email protected]
|
It will help. But of course, we might still have to backward-support slower hardware — at least if the 32-bit version is the same code-base as this Marlin. But I expect we will be making a whole separate repo for the 32-bit version. |
IMO we shall decide after refactoring the existing code and looking at the HAL. |
…Version_change Version changed (3.12.1 build 5684) for FW3.12.1
No description provided.