Fix issues with inconsistent order of includes across source files #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marlin.h always needs pins.h to be included before it, this was only done in some files and not others. Marlin.h now explicitly includes everything it needs. Also, include order was different for each source file, this has been cleaned up. Should fix issues with certain pin options not working properly or even compiling, such as the motor enable pins.
|
Any chance this will get pulled in soon? It's a pretty simple fix. |
|
I did overwork the includes today. Can you have a look and if it is allright for you? |
|
I think it's probably a good idea to limit the marlin.h includes just to the files that directly need access to the marlin configuration/pins stuff. Certainly, if we can avoid making changes to the files that are just included directly from other projects and don't use anything from marlin (I'm thinking of the SD card support here) then it's a bit easier to integrate fixes from their parent projects. That said, if it works, I'm okay with it as it is. Any changes I care enough about I'll put in a new pull request. |
rosenhouse
pushed a commit
to rosenhouse/Marlin
that referenced
this pull request
Feb 16, 2015
Missing "break;"
Closed
Christoph-D
pushed a commit
to Christoph-D/Marlin
that referenced
this pull request
Jun 1, 2020
Malderin
pushed a commit
to Malderin/Marlin_2.0.x_official
that referenced
this pull request
Dec 30, 2020
Add status in move menu
maz3max
pushed a commit
to maz3max/Marlin
that referenced
this pull request
Aug 24, 2021
classicrocker883
pushed a commit
to classicrocker883/Marlin
that referenced
this pull request
Oct 20, 2023
drewmoseley
pushed a commit
to drewmoseley/Marlin
that referenced
this pull request
Nov 8, 2023
* PFW-1351 WIP * Fix bug with cooldown timing due to bad bitfield. * Use default safety timer value for timeout
arades79
pushed a commit
to CELLINKAB/Marlin
that referenced
this pull request
Mar 15, 2024
Tmp117 error value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marlin.h always needs pins.h to be included before it, this was only
done in some files and not others. Marlin.h now explicitly includes
what it needs. Also, include order was different for each source
file, this has been cleaned up.
Should fix issues with certain pin options not working properly or even
compiling, such as the motor enable pins.