Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix menu homing feedrate display #27518

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

ellensp
Copy link
Contributor

@ellensp ellensp commented Nov 8, 2024

Description

The Menu homing feedrate displays incorrectly, repeating the axis name vs unique axis names.

Screenshot from 2024-11-05 17-19-00

Requirements

An appropriate LCD
#define EDITABLE_HOMING_FEEDRATE
optionally with
#define MENUS_ALLOW_INCH_UNITS and #define INCH_MODE_SUPPORT

Benefits

Menu displays correctly in both metric and imperial modes.

Configurations

Sim Configuration.zip

Related Issues

  • [BUG] Menu homing feedrate displays incorrectly #27513
  • @classicrocker883
    Copy link
    Contributor

    i know this sounds stupid and insignificant, but there are two spaces before \ here #define _EDIT_HOMING_FR(A) \

    @thinkyhead thinkyhead merged commit 70c3060 into MarlinFirmware:bugfix-2.1.x Nov 12, 2024
    64 checks passed
    @ellensp ellensp deleted the homing-feedrate-menu branch November 12, 2024 22:27
    bsdnomad pushed a commit to bsdnomad/Marlin that referenced this pull request Nov 25, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants