Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔨 Pins Debugging fix and cleanup #27494

Merged
merged 3 commits into from
Oct 27, 2024
Merged

🔨 Pins Debugging fix and cleanup #27494

merged 3 commits into from
Oct 27, 2024

Conversation

thinkyhead
Copy link
Member

@thinkyhead thinkyhead commented Oct 25, 2024 •
edited
Loading

  • Add comments indicating which macros / functions are required for pins debugging.
  • Apply consistent parameters with P/pin for pins, x/index for indexes.
  • Fix some incorrect macro parameters.
  • Fix some incorrect valid pin checks.
  • Add an #error for Teensy 3.x.
  • Simulator on macOS now requires Mesa for KHR/khrplatform.h.
  • Incomplete but building pins debugging for Teensy 3.5, SAMD21, SAMD51.
  • Standardize auto-assignment / undef of TMC UART RX/TX pins.

@thinkyhead thinkyhead added PR: Bug Fix T: Development Makefiles, PlatformIO, Python scripts, etc. labels Oct 25, 2024
@thinkyhead thinkyhead force-pushed the bf2_pins_debug_cleanup_PR branch 4 times, most recently from 3d4c27a to 7aee6e4 Compare October 26, 2024 01:06
@thinkyhead thinkyhead force-pushed the bf2_pins_debug_cleanup_PR branch from 7aee6e4 to 85c8e2a Compare October 27, 2024 18:38
@thinkyhead thinkyhead force-pushed the bf2_pins_debug_cleanup_PR branch from 85c8e2a to a3ae6f8 Compare October 27, 2024 18:54
@thinkyhead thinkyhead force-pushed the bf2_pins_debug_cleanup_PR branch 2 times, most recently from b325986 to cffd6b6 Compare October 27, 2024 19:00
@thinkyhead thinkyhead merged commit b4a3e29 into MarlinFirmware:bugfix-2.1.x Oct 27, 2024
64 checks passed
@thinkyhead thinkyhead deleted the bf2_pins_debug_cleanup_PR branch October 27, 2024 19:56
thisiskeithb added a commit to thisiskeithb/Configurations that referenced this pull request Nov 1, 2024
@thisiskeithb
💡 Update "default minimum feedrates" comments
f27eab1 
MarlinFirmware/Marlin#27494
@thisiskeithb thisiskeithb mentioned this pull request Nov 1, 2024
Merged
thinkyhead pushed a commit to MarlinFirmware/Configurations that referenced this pull request Nov 2, 2024
@thisiskeithb
💡 Update min feedrate comments (#1116)
d0b6134 
MarlinFirmware/Marlin#27494
rngkll pushed a commit to rngkll/Configurations that referenced this pull request Dec 5, 2024
@thisiskeithb @rngkll
💡 Update min feedrate comments (MarlinFirmware#1116)
bd7e7b8 
MarlinFirmware/Marlin#27494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Bug Fix T: Development Makefiles, PlatformIO, Python scripts, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thinkyhead