Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EDITABLE_HOMING_FEEDRATE menu to ProUI #27469

Open
wants to merge 9 commits into
base: bugfix-2.1.x
Choose a base branch
from

Conversation

classicrocker883
Copy link
Contributor

@classicrocker883 classicrocker883 commented Oct 10, 2024

Description

With the new EDITABLE_HOMING_FEEDRATE, this adds a menu option to ProUI to edit the homing feedrates.

  • Update limits.h
  • Add editable homing feedrate menu option
  • Small typo fix for menus.cpp
  • Typo in dwin.cpp hmiValue.axis = X_AXIS, set___ => hmiValue.axis = X_AXIS; set___
    example:
-   void setMaxJerkX() { hmiValue.axis = X_AXIS, setFloatOnClick(min_jerk_edit_values.x, max_jerk_edit_values.x, UNITFDIGITS, planner.max_jerk.x, applyMaxJerk); }

+   void setMaxJerkX() { hmiValue.axis = X_AXIS; setFloatOnClick(min_jerk_edit_values.x, max_jerk_edit_values.x, UNITFDIGITS, planner.max_jerk.x, applyMaxJerk); }

Requirements

Benefits

Configurations

Related Issues

One thing I would like changed - that I just can't figure out - is changing the homing feedrate from float to int because these values are in the thousands, if a user wants to change them through the UI, using a scroll may take much too long because of the precision in decimal place.

So if Homing is 3600.0, it takes many scrolls for a significant change, so changing this to an int simplifies things.

However it isn't as simple as changing setPFloatOnClick to setPIntOnClick, or onDrawPFloatMenu to onDrawPIntMenu.

I tried this and it breaks using it entirely.

I'm not sure the way to go about this so would be great for some help figuring this out.

This issue should be fixed now, added an intermittent value and static_cast as an int

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants