Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFT_COLOR_UI uses LCD_LANGUAGE #27454

Merged

Conversation

ellensp
Copy link
Contributor

@ellensp ellensp commented Oct 3, 2024

Description

Currently if your using a TFT_COLOR_UI and set LCD_LANGUAGE, LCD_LANGUAGE is removed as unused
TFT_COLOR_UI does use LCD_LANGUAGE

Found that LCD_LANGUAGE was being undefined and updated the check so LCD_LANGUAGE is not removed with TFT_COLOR_UI.

Requirements

TFT_COLOR_UI
#define LCD_LANGUAGE {annother lanugaue}

Benefits

Non English languages works on TFT_COLOR_UI

Configurations

From issue #27453
https://github.com/user-attachments/files/17241884/config.zip

Related Issues

  • [BUG] MARLINUI doesn't change language with MKS_TS35_V2_0 #27453
  • @thinkyhead thinkyhead merged commit df5d08a into MarlinFirmware:bugfix-2.1.x Oct 3, 2024
    63 checks passed
    @ellensp ellensp deleted the TFT_COLOR_UI-language branch October 3, 2024 21:31
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants