-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Typos #27325
Fix Typos #27325
Conversation
c792921
to
37fb26b
Compare
What is the purpose of your changes? What issue this PR solves? I don't really care if marlin maintainers are fine with that but it just looks weird. But more importantly, when you contribute to project this big this also leads to set of issues:
These kind of changes are never necessary unless:
Otherwise you create changes that will waste other people's time with no practical benefit. Considering that it's not the first PR that comes from you, it looks like you do have some strategy though. |
YAML is superset of JSON, and in JSON Also, according to YAML specs double quotes are defined as a way to define string (scalar in terms of YAML types). So it is unclear what you mean by "correct syntax" if |
meaning if you look up how this is supposed to be, the correct usage, not only that but looking at similar files use that same syntax. talk about a waste of time, look at how much you wrote for the very little changes, and now wasting my time. wow |
first I'm told not to piggypack code with other PR's because it would be irrelevant. to keep all the code separate. then I'm told keep it short because its easier and faster to get pulled/merged. now I'm told beneficial changes, no matter how small, aren't accepted unless it solves world hunger. well it is what it is. so what then? search for more Typos in order for this PR to be acceptable? or put it into an unrelated random one? |
37d77d6
to
aa44542
Compare
Description
)
to docs\ConfigEmbedding.md"
with'
incron:
in .github/workflows/close-stale.yml | .github/workflows/auto-label.yml, which is the correct sytaxRequirements
Benefits
Configurations
Related Issues