Fix firmware upload with Marlin Binary File Transfer

[PvtHaggard]

Description

When attempting to use Marlin Binary File Transfer to update firmware over UBS a FileNotFoundError is thrown.

Exception: [Errno 2] No such file or directory: 'firmware.bin', transfer aborted
Rollback: trying to delete firmware 'firmware.bin'...
Traceback (most recent call last):
File "C:\Users\Jordan\Documents\Arduino\Marlin-2.1.2.2\buildroot\share\scripts\upload.py", line 282, in Upload
transferOK = filetransfer.copy(upload_firmware_source_path, upload_firmware_target_name, upload_compression, upload_test)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\Jordan\Documents\Arduino\Marlin-2.1.2.2\buildroot\share\scripts\MarlinBinaryProtocol.py", line 405, in copy
data = open(filename, "rb").read()
^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: 'firmware.bin'

The fallback value of upload_firmware_source_name is a relative file path from the current working directory to the firmware. The string built using env["PROGNAME"] is just a filename and is not a valid path to the firmware. I have corrected the string built with env["PROGNAME"] to be an absolute path to the firmware, I have also changed the variable name upload_firmware_source_name to upload_firmware_source_path to reflect this.

upload_firmware_source_path = os.path.join(env["PROJECT_BUILD_DIR"], env["PIOENV"], f"{env['PROGNAME']}.bin") if 'PROGNAME' in env else str(source[0])

Requirements

Board: BigTreeTech SKR-mini-E3-V3.0
PlatformIO environment: STM32G0B1RE_btt_xfer
Marlin Features: BINARY_FILE_TRANSFER and CUSTOM_FIRMWARE_UPLOAD enabled

Configurations

Marlin-2.1.2.2.zip

[thisiskeithb]

File "C:\Users\Jordan\Documents\Arduino\Marlin-2.1.2.2

Have you tried BFT in bugfix-2.1.x? I thought this issue was resolved.

2.1.2.2 doesn't have all the latest patches.