🩹 Fix ESP3D WiFi Support #26822
Merged
🩹 Fix ESP3D WiFi Support #26822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
1 task
thisiskeithb
force-pushed
the
pr/fix_esp32-3d_wifi
branch
from
378d56a to
f563ca2
Compare
|
it works for me, thx. why is it not in branch?? |
Because this PR has not been merged yet. |
yes, but why ? :) i don't understand that, i am new in this, i see there are no conflicts message for two weeks. thx |
There are nearly 100 PRs in the queue and these things take time. |
thisiskeithb
force-pushed
the
pr/fix_esp32-3d_wifi
branch
from
f563ca2 to
5f0add7
Compare
sjasonsmith
reviewed
Apr 7, 2024
sjasonsmith
reviewed
Apr 7, 2024
This was referenced Apr 21, 2024
RPGFabi
pushed a commit
to RPGFabi/Marlin
that referenced
this pull request
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#26097 broke WiFi support for ESP3D on ESP32-based boards, so this PR brings back that functionality. See #26786 & luc-github/ESP3DLib#75 for more information.
CC: @luc-github
Requirements
ESP32-based motherboard with WiFi / ESP3DLib
Benefits
WiFi will work on these boards again.
Related Issues