-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix runout #26067
Fix runout #26067
Conversation
Converted to draft since the patch doesn’t seem to work: #26061 (comment) |
@GMagician Yes, looks like now it is counting runout mm correctly, at least with retract_test_ps_464_fw.gcode. But for some reason printer is reloading while printing. I checked that its behavior depends on MIN_STEPS_PER_SEGMENT value. I have used this branch to test patch https://github.com/GMagician/Marlin/tree/850d848e942682c284cd92174b304ec7b82f220d (as I understand it is current bugfix with patch applied) log_M1_LOG.txt - MIN_STEPS_PER_SEGMENT=1 with patch |
@justvlade I was sure not to reenter the calling block that may generate a loop but maybe I'm wrong. I approached in a different way this issue and if it runs it's a lot cleaner than this (and also more resources saver). May you try it? it's #26082 |
Replaced by #26082 |
May fix #26061
Needs a seriuous review before testing it
I decided to limit changes only when runout works with distance because it shouldn't be a problem in other cases