Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish changing DWIN_LevelingDone to dwinLevelingDone #25989

Closed
wants to merge 1 commit into from
Closed

Finish changing DWIN_LevelingDone to dwinLevelingDone #25989

wants to merge 1 commit into from

Conversation

Bob-the-Kuhn
Copy link
Contributor

@Bob-the-Kuhn Bob-the-Kuhn commented Jun 17, 2023 •
edited by thinkyhead
Loading

PR #25939 partially implemented changing the function name DWIN_LevelingDone to dwinLevelingDone. This PR finishes changing all occurrences of DWIN_LevelingDone to dwinLevelingDone.

Currently a compile error is generated when the Ender 3V2 -> CrealityV422->CrealityUI example config is run during Klemtest.

@thisiskeithb
Copy link
Member

thisiskeithb commented Jun 17, 2023 •
edited by thinkyhead
Loading

There’s also more work being done in #25982

@thinkyhead
Copy link
Member

  • This is already part of the delayed ProUI PR 🎨 More lowercase (ProUI) #25982, which is on hold pending a PR from @mriscoc coming soon.
  • The build for use_example_configs "Creality/Ender-3 V2/CrealityV422/CrealityUI" actually does succeed now.

@thinkyhead thinkyhead closed this Jun 17, 2023
@Bob-the-Kuhn Bob-the-Kuhn deleted the DWIN_LevelingDone branch June 19, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bob-the-Kuhn @thisiskeithb @thinkyhead