Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UBL_HILBERT_CURVE on BOARD_MKS_TINYBEE #25873

Merged
merged 1 commit into from
May 24, 2023
Merged

Fix UBL_HILBERT_CURVE on BOARD_MKS_TINYBEE #25873

merged 1 commit into from
May 24, 2023

Conversation

ellensp
Copy link
Contributor

@ellensp ellensp commented May 23, 2023 •
edited by thinkyhead
Loading

Description

UBL_HILBERT_CURVE fails to compile on BOARD_MKS_TINYBEE
Error "Marlin/src/feature/bedlevel/hilbert_curve.cpp:31:71: error: call of overloaded 'log2(int)' is ambiguous"

Explicitly defined the typres

Requirements

#define MOTHERBOARD BOARD_MKS_TINYBEE
#define FIX_MOUNTED_PROBE
#define AUTO_BED_LEVELING_UBL
#define UBL_HILBERT_CURVE
#define Z_SAFE_HOMING
#define EEPROM_SETTINGS

Benefits

Compiles as expected

Related Issues

#25870

@thinkyhead thinkyhead merged commit eb439b9 into MarlinFirmware:bugfix-2.1.x May 24, 2023
@ellensp ellensp deleted the fix-issue-UBL_HILBERT_CURVE branch May 24, 2023 07:59
ncksnydr added a commit to ncksnydr/Narungol-Marlin-Firmware that referenced this pull request May 24, 2023
@ncksnydr
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marlin…
8759f4c 
… into feature/bugfix-2.1.x

* 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marlin:
  🩹 Fix ESP32 compile error (MarlinFirmware#25873)
  🧑‍💻 Updated toolchain for ststm32@~14.1.0 (MarlinFirmware#25846)
  🧑‍💻 Misc. ExtUI LCD cleanup (MarlinFirmware#25872)
  [cron] Bump distribution date (2023-05-24)
  ✅ Update checkout actions
  [cron] Bump distribution date (2023-05-23)
tspiva pushed a commit to tspiva/Marlin that referenced this pull request May 25, 2023
@ellensp
🩹 Fix ESP32 compile error (MarlinFirmware#25873)
4804d26
Andy-Big pushed a commit to Andy-Big/Marlin_FB_Reborn that referenced this pull request Jul 15, 2023
@ellensp @Andy-Big
🩹 Fix ESP32 compile error (MarlinFirmware#25873)
da1a448
Andy-Big pushed a commit to Andy-Big/Marlin_FB_Reborn that referenced this pull request Jul 19, 2023
@ellensp @Andy-Big
🩹 Fix ESP32 compile error (MarlinFirmware#25873)
43f821c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: ESP32 PR: Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ellensp @thinkyhead