fix pro_ui delay boot loop issue. #25827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellensp
changed the title
|
That works! We'll recommend to ProUI users to use a
FYI dividing an integer by an integer in a function call taking an integer doesn't promote to a |
thinkyhead
pushed a commit
that referenced
this pull request
May 14, 2023
oponyx
pushed a commit
to oponyx/Marlin
that referenced
this pull request
May 15, 2023
oponyx
pushed a commit
to oponyx/Marlin
that referenced
this pull request
May 15, 2023
EvilGremlin
pushed a commit
to EvilGremlin/Marlin
that referenced
this pull request
May 17, 2023
tspiva
pushed a commit
to tspiva/Marlin
that referenced
this pull request
May 25, 2023
Andy-Big
pushed a commit
to Andy-Big/Marlin_FB_Reborn
that referenced
this pull request
Jul 15, 2023
Andy-Big
pushed a commit
to Andy-Big/Marlin_FB_Reborn
that referenced
this pull request
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since 4528fde PRO_UI causes a boot loop
The issue is the delay. originally delay(50) is now delay((BOOTSCREEN_TIMEOUT) / 22);
The default BOOTSCREEN_TIMEOUT in Configuration_adv.h is 4000 resulting in a float (181.818181818) and causing a watchdog timeout.
Added a millis_t type conversion and used safe_delay and the issue is resolved.
Requirements
PRO_UI
Benefits
Works as expected
Related Issues
#25786