Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable REINIT_NOISY_LCD for HAS_DWIN_E3V2 #23880

Closed

Conversation

ellensp
Copy link
Contributor

@ellensp ellensp commented Mar 10, 2022

Description

REINIT_NOISY_LCD is incorrectly enabled for some E3V2 displays in error.

Half the E3V2 gui's are accounted for with checking for IS_DWIN_MARLINUI
but HAS_DWIN_E3V2 is not checked so DWIN_CREALITY_LCD_ENHANCED and DWIN_CREALITY_LCD_JYERSUI both incorrectly enable REINIT_NOISY_LCD which causes issues such as #23877

Requirements

DWIN_CREALITY_LCD_ENHANCED or DWIN_CREALITY_LCD_JYERSUI

Benefits

Display doesn't show second startup progress bar

Related Issues

#23877

@ellensp
Copy link
Contributor Author

ellensp commented Mar 10, 2022

already in #23879

@ellensp ellensp closed this Mar 10, 2022
@ellensp ellensp deleted the REINIT_NOISY_LCD branch March 10, 2022 11:14
@steljwagh
Copy link
Contributor

I didnt see this PR, I wanted to save you some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants