Added tramming sanity checks #21009
Closed
Added tramming sanity checks #21009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected tramming refernce from nozzle to probe comment
The comment isn't wrong. The coordinates are absolute in the XY plane. |
|
Please make your modifications to the bugfix-2.0.x branch. |
|
@arjanmels as you may have already discovered, the sanity checks duplicate work I already submitted a while ago, but they probably aren't in a labeled release yet: |
|
@sjasonsmith I noticed when I tried to merge in the bugfix branch. Thank you for this and the other work on the tramming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Requirements
None
Benefits
Corrected configuration comment and additional sanity checks. The sanity check will prevent users from entering wrong tramming coordinates, which otherwise would only be caught at run-time
Configurations
#define ASSISTED_TRAMMING
Related Issues
N/A