[FIX] PWC - Setup killpin/powerhold ASAP or printer suicides #20810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rockman18
changed the title
|
Did you test this ? (I don't have the configuration to test it). |
X-Ryl669
reviewed
Jan 21, 2021
|
Yes i've tested it. It fixed my issue. I don't know but I wonder if only powerhold would be enough. |
TyMi
pushed a commit
to TyMi/Marlin
that referenced
this pull request
Jan 25, 2021
…_bugfix * commit '876c2586b9146dd123af4c7b21138b8239ef5d39': (116 commits) Clean up MMU2 code (MarlinFirmware#20794) Init KILL, SUICIDE, PSU earlier (MarlinFirmware#20810) "Move … code" followup (MarlinFirmware#20869) Apply SEC_TO_MS and other fixes Reformat abortSDPrinting Fix sign warning (MarlinFirmware#20872) Cosmetic changes (2) (MarlinFirmware#20876) "Move … code" followup (MarlinFirmware#20868) "Move … code" followup (MarlinFirmware#20874) Graphical TFT fixes, cleanup (MarlinFirmware#20861) 🧻 Cosmetic changes (MarlinFirmware#20859) 🛠Fix deps script version regex Fix Ender 3 V2 DWIN manual move (MarlinFirmware#20837) [cron] Bump distribution date (2021-01-25) Fix LiquidCrystal CI failures (MarlinFirmware#20873) Revert "Adding custom move feedrate for G26 (MarlinFirmware#20729)" (MarlinFirmware#20870) MeatPack serial encoding (MarlinFirmware#20802) [cron] Bump distribution date (2021-01-24) lcd_put_wchar_max for COLOR_UI (MarlinFirmware#20838) Adding custom move feedrate for G26 (MarlinFirmware#20729) ... # Conflicts: # Marlin/Configuration.h # Marlin/Configuration_adv.h
This was referenced Jan 30, 2021
Jyers
pushed a commit
to Jyers/Marlin
that referenced
this pull request
Feb 3, 2021
kpishere
pushed a commit
to kpishere/Marlin
that referenced
this pull request
Feb 19, 2021
|
hello, now the psu pin on SKR pro 1.1 don't turn on -_-" Before :
After :
|
zillarob
pushed a commit
to zillarob/Marlin
that referenced
this pull request
Feb 25, 2021
Evg33
added a commit
to Evg33/Marlin
that referenced
this pull request
Feb 25, 2021
W4tel-BiDi
pushed a commit
to W4tel-BiDi/Marlin
that referenced
this pull request
Apr 5, 2021
thinkyhead
pushed a commit
to thinkyhead/Marlin
that referenced
this pull request
Apr 29, 2021
thinkyhead
pushed a commit
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fix the issue detected during MKS_WIFI_MODULE release (#20191). With a PWC the printer suicides during the serial init of the MKS wifi. The setup of killpin/powerhold occurs too late in the process.
Requirements
Benefits
The printer doesn't suicide during init.
Configurations
N/A
Related Issues
#20191 (comment)