Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nozzle-to-Probe offsets unit comment #20633

Closed

Conversation

qwewer0
Copy link
Contributor

@qwewer0 qwewer0 commented Jan 2, 2021

Description

Add Nozzle-to-Probe offsets mm unit in the comment to avoid misunderstandings.

Benefits

Less misunderstanding.

Related Issues

#18584

@qwewer0
Copy link
Contributor Author

qwewer0 commented Jan 2, 2021

Not sure why would a comment change fail the checks.

@qwewer0 qwewer0 mentioned this pull request Jan 2, 2021
@thinkyhead thinkyhead marked this pull request as ready for review January 3, 2021 01:22
@thinkyhead
Copy link
Member

Every single length unit in Marlin is expressed in millimeters. Where is the confusion?

@qwewer0
Copy link
Contributor Author

qwewer0 commented Jan 3, 2021

Every single length unit in Marlin is expressed in millimeters. Where is the confusion?

I wouldn't think there is way to be confused about the length unit, yet users find a way. If it is already clear enough (I think it is), then this can be closed along with #18584

@thinkyhead thinkyhead closed this Jan 3, 2021
@qwewer0 qwewer0 deleted the Probe_Offset_Unit branch January 3, 2021 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants